Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] fix: fixed design token for icon btn active state #2765

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Oct 30, 2023

Description

  • The inverse-primary IconButton component does not have a white background;
  • Fixed path to the build directory.

Issue: #2688

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Oct 30, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 69e2590
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/653fc13a8b46700009e6ae74
😎 Deploy Preview https://deploy-preview-2765--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.28%. Comparing base (0a809ed) to head (69e2590).
Report is 740 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #2765      +/-   ##
==========================================
+ Coverage   92.82%   93.28%   +0.46%     
==========================================
  Files         235      215      -20     
  Lines        4237     3635     -602     
  Branches     1029      898     -131     
==========================================
- Hits         3933     3391     -542     
+ Misses        300      239      -61     
- Partials        4        5       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viktorrusakov viktorrusakov merged commit 56836f0 into openedx:alpha Oct 30, 2023
8 checks passed
@openedx-webhooks
Copy link

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 22.0.0-alpha.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot

🎉 This PR is included in version 23.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

PKulkoRaccoonGang added a commit that referenced this pull request Aug 1, 2024
* fix: fixed design token for icon btn active state

* fix: fixed path to build directory
PKulkoRaccoonGang added a commit that referenced this pull request Aug 4, 2024
* fix: fixed design token for icon btn active state

* fix: fixed path to build directory
PKulkoRaccoonGang added a commit that referenced this pull request Aug 4, 2024
* fix: fixed design token for icon btn active state

* fix: fixed path to build directory
PKulkoRaccoonGang added a commit that referenced this pull request Aug 5, 2024
* fix: fixed design token for icon btn active state

* fix: fixed path to build directory
@openedx-semantic-release-bot

🎉 This PR is included in version 23.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha released
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[alpha] The primary IconButton component does not have a white background
5 participants