Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate tests from enzyme to react-testing-library #2325

Closed
1 task
Tracked by #195
viktorrusakov opened this issue May 23, 2023 · 1 comment · Fixed by #2581
Closed
1 task
Tracked by #195

Migrate tests from enzyme to react-testing-library #2325

viktorrusakov opened this issue May 23, 2023 · 1 comment · Fixed by #2581
Assignees
@monteri
Labels
engineering Engineering epic Large unit of work, consisting of multiple tasks maintenance Routine upkeep necessary for the health of the platform raccoon-gang

Comments

@viktorrusakov
Copy link
Contributor

viktorrusakov commented May 23, 2023 •
edited by adamstankiewicz
Loading

During upgrade to React 18 it was discovered that enzyme has no support for React 18 and it breaks a lot of our tests. Furthermore, there is no plans of making eznyme adapter for React 18, meaning our tests will never pass with React 18 (unless we use some unofficial adapter like this one, which we really shouldn't be doing).

We can solve this problem by fully migrating our tests to react-testing-library and/or react-test-renderer, which we already use in a bunch of our tests. React-testing-library supports React 18 starting from v13.0.0 and nowadays it is recommended tool for testing React applications. This would unblock our upgrade to React 18.

AC
Preview Give feedback
@viktorrusakov viktorrusakov added awaiting prioritization maintenance Routine upkeep necessary for the health of the platform engineering Engineering epic Large unit of work, consisting of multiple tasks labels May 23, 2023
@viktorrusakov viktorrusakov mentioned this issue May 23, 2023
Closed
10 tasks
@adamstankiewicz adamstankiewicz moved this from Backlog to To Do in Paragon Working Group Jun 17, 2023
@monteri monteri self-assigned this Jun 27, 2023
@monteri monteri moved this from To Do to In progress in Paragon Working Group Jul 4, 2023
@MaxFrank13 MaxFrank13 mentioned this issue Jul 21, 2023
Merged
10 tasks
@khudym
Copy link
Contributor

khudym commented Aug 30, 2023

PR: #2581

@adamstankiewicz adamstankiewicz linked a pull request Sep 1, 2023 that will close this issue
[BD-46] feat: move Enzyme to React testing library #2440 #2581
Merged
10 tasks
@monteri monteri moved this from In progress to In review in Paragon Working Group Sep 8, 2023
@github-project-automation github-project-automation bot moved this from In review to Done in Paragon Working Group Oct 12, 2023
@arbrandes arbrandes mentioned this issue Mar 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monteri monteri

Labels
engineering Engineering epic Large unit of work, consisting of multiple tasks maintenance Routine upkeep necessary for the health of the platform raccoon-gang
Projects
Paragon Working Group
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BD-46] feat: move Enzyme to React testing library #2440 khudym/paragon
4 participants
@adamstankiewicz @monteri @khudym @viktorrusakov