chore: replace 'global' with 'globalThis'

[bradenmacdonald]

The global keyword is a non-standard NodeJS specific keyword. But since 2019, we can use globalThis instead, which works in every runtime. For example, globalThis has the same consistent meaning in both browsers and NodeJS, whereas global does not work in browsers unless you use some build process to rewrite it to window.

Details: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/globalThis#description

Example from Chrome console:

[openedx-webhooks]

Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.41%. Comparing base (9d2e727) to head (d331922).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #701   +/-   ##
=======================================
  Coverage   83.41%   83.41%           
=======================================
  Files          40       40           
  Lines        1073     1073           
  Branches      197      197           
=======================================
  Hits          895      895           
  Misses        166      166           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[adamstankiewicz]

Seems reasonable. LGTM!

[openedx-webhooks]

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

[adamstankiewicz]

@bradenmacdonald [curious] Lots of repos use global today; I'm wondering if we should update the base ESLint config defined in @openedx/frontend-build so each consuming shared JS library and/or MFE doesn't need to specify this config across many different repos. Curious your two cents.

On a similar note, I wonder if it'd be more acceptable to extend the shared ESLint config's env option to include es2020 so that other similar syntax is deemed acceptable as well? @openedx/frontend-build relies on the env defined in @edx/eslint-config here. Setting es2020 in env would in place of configuring the globals for globalThis explicitly.

[bradenmacdonald]

Yes, I'm definitely in favor of setting es2020 in env as a default!

[adamstankiewicz]

@bradenmacdonald Opened a PR to the base shared ESLint configuration (@edx/eslint-config): openedx/eslint-config#153

I believe having es2020 in there would eliminate the need to keep es6, since the environments (as far as I can tell) are cumulative/additive, where a later environment supersedes an earlier one. That said, I'm opting to keep es6 in there for now just in case that is not true.

Let me know your thoughts; will also share in FWG Slack :)