Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass legacy status of exam to failure thunk #138

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

alangsto
Copy link
Contributor

COSMO-182

All thunks which result in a call to update an attempt status should account for whether or not the exam attempt is for a non-LTI provider. If the legacy status is not passed to the thunk, in this case endExamWithFailure, the frontend will only call edx-exams, which does not support routing PUT requests to update an attempt status back to edx-proctoring.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (8457727) 94.13% compared to head (c01253b) 93.25%.
Report is 4 commits behind head on main.

Files Patch % Lines
src/timer/TimerProvider.jsx 71.42% 2 Missing ⚠️
src/core/SequenceExamWrapper.jsx 0.00% 1 Missing ⚠️
src/exam/Exam.jsx 80.00% 1 Missing ⚠️
...arding_exam/EntranceOnboardingExamInstructions.jsx 66.66% 1 Missing ⚠️
...nboarding_exam/ErrorOnboardingExamInstructions.jsx 50.00% 1 Missing ⚠️
...arding_exam/RejectedOnboardingExamInstructions.jsx 66.66% 1 Missing ⚠️
...rding_exam/SubmittedOnboardingExamInstructions.jsx 66.66% 1 Missing ⚠️
...practice_exam/EntrancePracticeExamInstructions.jsx 50.00% 1 Missing ⚠️
...ns/practice_exam/ErrorPracticeExamInstructions.jsx 50.00% 1 Missing ⚠️
...ractice_exam/SubmittedPracticeExamInstructions.jsx 50.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   94.13%   93.25%   -0.89%     
==========================================
  Files          71       68       -3     
  Lines        1058     1052       -6     
  Branches      289      291       +2     
==========================================
- Hits          996      981      -15     
- Misses         57       66       +9     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@varshamenon4 varshamenon4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@alangsto alangsto merged commit 7cf0be5 into main Feb 13, 2024
6 of 10 checks passed
@alangsto alangsto deleted the alangsto/pass_legacy_attempt_to_expire branch February 13, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants