You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@openedx/paragon is installed as a dependency within package.json for this repo. As a result, Paragon is included as part of the code bundle generated by frontend-component-header. Given this, consumers (MFEs) using frontend-component-header are effectively requiring users to download duplicate copies of Paragon (more than likely at different versions, too): one copy of Paragon for the MFE and another copy of Paragon for frontend-component-header.
That said, because Paragon supports tree shaking, only the components directly used by frontend-component-header are included in the bundle (i.e., not the entire library).
Generally, Paragon should be treated as a peer dependency in Open edX JS libraries, relying on the installed version of Paragon provided by the consumer (MFE). For some reason, the peer dependency was (incorrectly) removed in favor of a regular dependency in this PR.
The text was updated successfully, but these errors were encountered:
adamstankiewicz
changed the title
Paragon is installed as a dependency instead treated as peer dependency
Paragon installed as dependency instead peer dependency
Jan 11, 2024
adamstankiewicz
changed the title
Paragon installed as dependency instead peer dependency
Paragon installed as dependency instead of peer dependency
Jan 11, 2024
@openedx/paragon
is installed as a dependency within package.json for this repo. As a result, Paragon is included as part of the code bundle generated byfrontend-component-header
. Given this, consumers (MFEs) usingfrontend-component-header
are effectively requiring users to download duplicate copies of Paragon (more than likely at different versions, too): one copy of Paragon for the MFE and another copy of Paragon forfrontend-component-header
.That said, because Paragon supports tree shaking, only the components directly used by
frontend-component-header
are included in the bundle (i.e., not the entire library).Generally, Paragon should be treated as a peer dependency in Open edX JS libraries, relying on the installed version of Paragon provided by the consumer (MFE). For some reason, the peer dependency was (incorrectly) removed in favor of a regular dependency in this PR.
The text was updated successfully, but these errors were encountered: