Add CoursewareSearchForm component #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidnuon
changed the base branch from
master
to
rijuma/courseware-search-modal
davidnuon
force-pushed
the
dnuon/courseware-search-component
branch
from
e074643 to
f7508f2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1214 +/- ##
==========================================
+ Coverage 88.18% 88.19% +0.01%
==========================================
Files 270 271 +1
Lines 4587 4591 +4
Branches 1151 1151
==========================================
+ Hits 4045 4049 +4
Misses 528 528
Partials 14 14
☔ View full report in Codecov by Sentry. |
aethant
reviewed
Oct 20, 2023
rijuma
reviewed
Oct 20, 2023
rijuma
reviewed
Oct 20, 2023
|
@davidnuon I think it has to be "fix:" rather than "lint: Fix" for the check to pass |
davidnuon
changed the title
davidnuon
force-pushed
the
dnuon/courseware-search-component
branch
from
b488581 to
bd3c69d
Compare
aethant
approved these changes
Oct 24, 2023
CefBoud
pushed a commit
to open-craft/frontend-app-learning
that referenced
this pull request
Nov 5, 2023
* feat: Add CoursewareSearchBar component * fix: lint * fix: Clarified component names and i18n description * test: Add more tests * fix: lint * fix: Made props in CoursewareSearchForm optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: KBK-41
Adds a search bar for the Courseware Search feature.
Depends on #1212