Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in remove capability for group members + csv download #1367

Merged
merged 15 commits into from
Jan 10, 2025

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Dec 12, 2024

Screenshot 2025-01-07 at 11 13 04 AM Screenshot 2025-01-07 at 11 14 50 AM

Jira ticket

Testing plan

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 18 lines in your changes missing coverage. Please review.

Project coverage is 85.71%. Comparing base (a13b2a7) to head (9876b29).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...leManagement/GroupDetailPage/RemoveMemberModal.jsx 33.33% 10 Missing ⚠️
.../data/hooks/useEnterpriseGroupLearnersTableData.js 33.33% 4 Missing ⚠️
...nagement/GroupDetailPage/DownloadCsvIconButton.jsx 90.90% 2 Missing ⚠️
src/components/PeopleManagement/constants.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1367      +/-   ##
==========================================
- Coverage   85.79%   85.71%   -0.09%     
==========================================
  Files         623      625       +2     
  Lines       13589    13638      +49     
  Branches     2851     2848       -3     
==========================================
+ Hits        11659    11690      +31     
- Misses       1860     1878      +18     
  Partials       70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiram15 kiram15 merged commit 0716be5 into master Jan 10, 2025
4 of 6 checks passed
@kiram15 kiram15 deleted the kiram15/ENT-9526 branch January 10, 2025 18:29
katrinan029 pushed a commit that referenced this pull request Jan 11, 2025
* fix: formatting without data

* fix: adding in tests

* fix: teeny fix

* feat: adding in remove member functionality

* fix: adding csv download

* fix: adding in download capability

* fix: remove formatting changes

* fix: PR requests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants