feat: write reversal on LC enrollment revoked event #282
+393
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me. |
pwnage101
force-pushed
the
pwnage101/ENT-9213
branch
3 times, most recently
from
05d820f to
3375576
Compare
|
I don't know why the PII checker is barfing, but maybe related to weird openedx-events requirement (hard-coded URL with hash). Trust me tests pass. |
brobro10000
reviewed
Aug 8, 2024
requirements/constraints.txt
Outdated
Comment on lines
21
to
22
|
|
||
| git+https://github.com/pwnage101/openedx-events.git@f00926ae93e84a114779a0e9c98c152e8927706d#egg=openedx_events |
There was a problem hiding this comment.
[nit] do these need to be removed from all the requiremetns files before its merged?
There was a problem hiding this comment.
yea, this PR is blocked on merging my openedx-events PR, after which point I'll update this PR to have normal requirements.
iloveagent57
approved these changes
Aug 8, 2024
pwnage101
force-pushed
the
pwnage101/ENT-9213
branch
2 times, most recently
from
f1f8f88 to
b084558
Compare
pwnage101
force-pushed
the
pwnage101/ENT-9213
branch
2 times, most recently
from
ef53136 to
64f7ec7
Compare
Handle the following event bus event: org.openedx.enterprise.learner_credit_course_enrollment.revoked.v1
under the following openedx-signal: LEARNER_CREDIT_COURSE_ENROLLMENT_REVOKED
This will perform the same duties as the
`write_reversals_from_enterprise_unenrollments` management command,
except it operates on only one unenrollment at a time, and no longer
calls the "recent unenrollments" API located at:
{LMS_BASE_URL}/enterprise/api/v1/operator/enterprise-subsidy-fulfillment/unenrolled/
ENT-9213
…LATION This setting is True in all internal environments now.
pwnage101
force-pushed
the
pwnage101/ENT-9213
branch
from
64f7ec7 to
1589455
Compare
|
I added a 3rd commit to do a couple things:
|
pwnage101
force-pushed
the
pwnage101/ENT-9213
branch
from
1589455 to
b868117
Compare
iloveagent57
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the following event bus event:
org.openedx.enterprise.learner_credit_course_enrollment.revoked.v1under the following openedx-events signal:
LEARNER_CREDIT_COURSE_ENROLLMENT_REVOKEDThis will perform the same duties as the
write_reversals_from_enterprise_unenrollmentsmanagement command, except it operates on only one unenrollment at a time, and no longer calls the "recent unenrollments" API located at:{LMS_BASE_URL}/enterprise/api/v1/operator/enterprise-subsidy-fulfillment/unenrolled/ENT-9213