Adding oauth test #35417
Adding oauth test #35417
Conversation
awais786
force-pushed
the
adding-oauth-test
branch
from
038741a to
981dcc4
Compare
|
@feanil Please review. |
| ) | ||
| return response | ||
|
|
||
| def test_end_points_with_oauth_without_jwt(self): |
There was a problem hiding this comment.
We should create a common function to avoid duplicating the code in all test cases.
Example:
Create a function similar to
def run_endpoint_tests(self, expected_status, add_role, use_jwt):
containing all the duplicate code so the actual tests can be changed to something like following:
def test_end_points_with_oauth_without_jwt(self):
self.run_endpoint_tests(expected_status=401, add_role=False, use_jwt=False)
There was a problem hiding this comment.
@UsamaSadiq good suggestion, I have implemented.
| } | ||
|
|
||
| # endpoints contains all urls with body and role. | ||
| self.endpoints = [ |
There was a problem hiding this comment.
Why are we only testing these specific endpoints?
Do they belong to a particular feature?
There was a problem hiding this comment.
I am converting these endpoints to DRF. So now they all are oauth2 compatible.
There was a problem hiding this comment.
Perhaps we can organize this endpoints list in a maintainable way, for example define the endpoints in the constants in next PRs
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Added OAuth tests for various instructor URLs.
This PR includes authentication of URLs using OAuth2 and testing access to recently converted Django Rest Framework (DRF) endpoints."