-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [FC-0074] add inline code annotation linter for Open edX Events #478
base: master
Are you sure you want to change the base?
feat: [FC-0074] add inline code annotation linter for Open edX Events #478
Conversation
Thanks for the pull request, @mariajgrimaldi! This repository is currently maintained by @openedx/axim-engineering. Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
This looks good to me, but I don't know this repo well (and am not a CC on it) so I can't provide an approving review. |
Thank you, @sarina. I'll tag @openedx/axim-engineering as the owners according to the catalog-info.yaml. |
Description:
This PR adds a linter for events code-annotations to find missing required fields like: name, type, data and description for Open edX Events. If any of these fields are missing, then a quality error is raised.
You can see it working in this PR: openedx/openedx-events#448 by running
pylint openedx_events/learning/signals.py
:This linter aims to enforce the standard of in-line code annotations for developers to follow when documenting events definitions in the openedx-events (and others) repositories.
I'm open to moving this directly into the openedx-events repo if needed, considering that the linter is kind of specific to that repository.
Merge checklist: