Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discovery: Renovate config options and consistency #966

Closed
feanil opened this issue Nov 6, 2023 · 7 comments
Closed

Discovery: Renovate config options and consistency #966

feanil opened this issue Nov 6, 2023 · 7 comments
Assignees
@salman2013

Comments

@feanil
Copy link
Contributor

feanil commented Nov 6, 2023

What are the different options for renovate config? Can we standardize?

We use Renovate to manage JS upgrade in various repositories. It should be standard across all JS repos but we don't know that it is.

Questions to answer

  • How many repos have a package.json file?
  • How many repos have renovate config?
  • How many different variations on renovate config is there?
  • Can you recommend any changes to the default renovate config?

Expected Output

  • Comments on this ticket that answer the above questions and any other things you learn along the way.
  • Recommendation on whether or not it makes sense to standardise the renovate config.
  • Discussion based on learnings.
    • This might result in the creation of tickets to go through the standardization.
@feanil feanil converted this from a draft issue Nov 6, 2023
@feanil feanil moved this from 🆕 New to 🔖 Ready in Aximprovements Team Nov 6, 2023
@salman2013 salman2013 self-assigned this Nov 20, 2023
@farhan farhan moved this from 🔖 Ready to 🏗 In progress in Aximprovements Team Nov 27, 2023
@salman2013
Copy link

salman2013 commented Nov 29, 2023 •
edited
Loading

How many repos have a package.json file?

I found the following repositories having package.json file

https://github.com/search?q=org%3Aopenedx+Package.json+language%3AJSON&type=code&l=JSON&p=5

How many repos have renovate config?

A total of 23 repositories have a renovate.json file

  1. https://github.com/openedx/frontend-app-publisher
  2. https://github.com/openedx/frontend-app-admin-portal
  3. https://github.com/openedx/frontend-app-profile
  4. https://github.com/openedx/frontend-app-ecommerce
  5. https://github.com/openedx/frontend-app-account
  6. https://github.com/openedx/frontend-app-payment
  7. https://github.com/openedx/frontend-app-learning
  8. https://github.com/edx/prospectus
  9. https://github.com/openedx/frontend-app-learner-portal-enterprise
  10. https://github.com/openedx/frontend-app-course-authoring
  11. https://github.com/openedx/frontend-app-library-authoring
  12. https://github.com/edx/frontend-app-learner-record
  13. https://github.com/openedx/frontend-app-enterprise-public-catalog
  14. https://github.com/edx/frontend-app-communications
  15. https://github.com/openedx/paragon
  16. https://github.com/openedx/frontend-platform
  17. https://github.com/openedx/frontend-build
  18. https://github.com/openedx/frontend-component-header
  19. https://github.com/edx/frontend-component-header-edx
  20. https://github.com/openedx/frontend-component-cookie-policy-banner
  21. https://github.com/edx/frontend-component-footer-edx
  22. https://github.com/openedx/frontend-component-footer
  23. https://github.com/openedx/frontend-template-application

The following repos have both package.json file and renovate.json file

  1. https://github.com/openedx/frontend-app-publisher
  2. https://github.com/openedx/frontend-app-admin-portal
  3. https://github.com/openedx/frontend-app-profile
  4. https://github.com/openedx/frontend-app-ecommerce
  5. https://github.com/openedx/frontend-app-account
  6. https://github.com/openedx/frontend-app-payment
  7. https://github.com/openedx/frontend-app-learning
  8. https://github.com/openedx/frontend-app-learner-portal-enterprise
  9. https://github.com/openedx/frontend-app-course-authoring
  10. https://github.com/openedx/frontend-app-library-authoring
  11. https://github.com/openedx/frontend-app-enterprise-public-catalog
  12. https://github.com/openedx/paragon
  13. https://github.com/openedx/frontend-platform
  14. https://github.com/openedx/frontend-build
  15. https://github.com/openedx/frontend-component-header
  16. https://github.com/openedx/frontend-component-cookie-policy-banner
  17. https://github.com/openedx/frontend-component-footer
  18. https://github.com/openedx/frontend-template-application

I found a ticket to create a common renovate config that automates @edx namespaced minor/patch version upgrades, which means there is already progress to make the renovate config standardized for all repos.

There is also a sheet having information about all repos which are updated the renovate for @opendx packages

@feanil
Copy link
Contributor Author

feanil commented Dec 5, 2023

I found three repositories having package.json file

This doesn't seem right, there should be one in each MFE at least along with many of the libraries and older backends.

@salman2013
Copy link

@feanil I have updated the correct count and repo names which have package.json file in them.

@feanil
Copy link
Contributor Author

feanil commented Dec 15, 2023

@salman2013 do all of those repos have a renovate config?

@salman2013
Copy link

salman2013 commented Dec 19, 2023 •
edited
Loading

@feanil I updated the list of all repos which has both package.json and renovate.json files.

The following repos have both package.json file and renovate.json file

https://github.com/openedx/frontend-app-publisher
https://github.com/openedx/frontend-app-admin-portal
https://github.com/openedx/frontend-app-profile
https://github.com/openedx/frontend-app-ecommerce
https://github.com/openedx/frontend-app-account
https://github.com/openedx/frontend-app-payment
https://github.com/openedx/frontend-app-learning
https://github.com/openedx/frontend-app-learner-portal-enterprise
https://github.com/openedx/frontend-app-course-authoring
https://github.com/openedx/frontend-app-library-authoring
https://github.com/openedx/frontend-app-enterprise-public-catalog
https://github.com/openedx/paragon
https://github.com/openedx/frontend-platform
https://github.com/openedx/frontend-build
https://github.com/openedx/frontend-component-header
https://github.com/openedx/frontend-component-cookie-policy-banner
https://github.com/openedx/frontend-component-footer
https://github.com/openedx/frontend-template-application

@feanil
Copy link
Contributor Author

feanil commented Dec 19, 2023

@salman2013 let's make a ticket to ensure that the rest of the repos have a renovate.json config

@salman2013 salman2013 moved this from 🏗 In progress to 👀 In review in Aximprovements Team Dec 21, 2023
@salman2013 salman2013 moved this from 👀 In review to ✅ Done in Aximprovements Team Jan 3, 2024
@sarina
Copy link
Contributor

sarina commented Jul 1, 2024

Can this ticket be closed?

@github-project-automation github-project-automation bot moved this from Backlog to Done in Axim Engineering Tasks Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@salman2013 salman2013

Labels
None yet
Projects
Axim Engineering Tasks
Status: Done
Aximprovements Team
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@feanil @sarina @salman2013