-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH Request] Github integration request from 2U #1336
Comments
Thank you for your report! @openedx/axim-oncall will triage within a business day. Simple requests usually take 2-3 business days to resolve; more complex requests could take longer. |
Hi @deborahgu . I didn't manage to get to this before the holidays, but I'll follow up in the week of Jan 6. I'll need to talk my team a bit. For full transparency, I think I'm comfortable with this from a security perspective, but before moving forward with it, I would want to make sure that this is the type of thing that Axim would be willing to do for any actively involved Open edX deployer who asked. |
thanks! and to be very very clear, I think I'm making a hell of an ask and nobody at 2U would be surprised at all if you said no. I just figured it was worth asking. ❤️ Have a great holiday! |
@deborahgu I'm trying to do a dry-run of the setup process, just to ensure I fully understand the scope of the integration. I'm not able to get to a screen that looks like the one in the issue description. I've tried following these steps but I think I need to be authenticated into DataDog to use that workflow. Will one of need both a 2U DataDog account and the Admin Role in the openedx GH org? Or is there some other way through the setup I'm not seeing? |
@kdmccormick: I'll reach out to you directly. |
Here's what we (Axim) would need to be OK with this integration:
I've put the ball in @robrap 's court to try to ensure those things. If we are good on all those points, then I think this integration would be a "go" |
Thanks @kdmccormick. I have opened a ticket with DD (private link).
|
Firm Name
2U
Urgency
Low (2 weeks)
Problem/Request
hi, this conversation was initially raised in #ask-axim.
Is there any possibility Axim would be open to letting 2U configure our Datadog instance to have the Github integration with the OpenEdX public repositories? Based on the docs and the setup config (picture pasted below), it should be simple to make it read only, and for public information only.
We would be requesting read-only access for Contents, Actions, Pull Requests, and Issues.
Note: If the openedx org contains any private repositories, actions, PRs, or issues, I suppose those would have a risk of being exposed; as a non-permissioned user I obviously don't know if any of those exist.
@robrap is willing to be a resource on this, if Axim approves.
DD allows fine-grained permission configuration on the integration, and this is what we would be requesting:
We also be able to get by with just Contents, honestly. The other 3 would add a couple of nice features but Contents is the big one.
Reasoning
This would allow Datadog to see our catalog-info.yml files, to link errors to lines of code, etc. I understand this might be a nonstarter, but it would make my life materially easier so I figured it was worth asking!
The text was updated successfully, but these errors were encountered: