Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH Request] remove email secrets from frontend-app-learner-dashboard #1323

Closed
deborahgu opened this issue Dec 6, 2024 · 2 comments
Closed
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.

Comments

@deborahgu
Copy link
Member

Repository

axim-engineering

Urgency

Low (2 weeks)

Requested Change

  1. Reply to this letting us know that you're fine with maintainers removing Send failure notification from the repo CI.
  2. remove EDX_SMTP_USERNAME and EDX_SMTP_PASSWORD from the frontend-app-learner-dashboard secrets.

Reasoning

The Send failure notification has been intermittently failing for a very long time. We, the code maintainers, could debug this. But we also have a workflow where we proactively check CI test results, and don't need the email. If Axim's okay with it, we'd rather just remove the email action here.

@deborahgu deborahgu added the github-request Request for change to access level or settings in the openedx GitHub organization. label Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

Thank you for your report! @openedx/axim-oncall will triage within a business day. Simple requests usually take 2-3 business days to resolve; more complex requests could take longer.

@feanil
Copy link
Contributor

feanil commented Dec 9, 2024

@deborahgu that sounds fine, the SMTP secrets are global to the org but you're welcome to drop this if you're checking CI regularly. I think one of the reasons for this e-mail is that it runs the check on master as well and which you won't easily see on a PR. However, if you still want that you can also just get notifications directly from github.

@feanil feanil closed this as completed Dec 9, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Axim Engineering Tasks Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.
Projects
Status: Done
Development

No branches or pull requests

2 participants