Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

fix: Replace Rectangle-only image with an image that can work with sq… #6

Conversation

jswope00
Copy link
Contributor

…uare cropping

The original thumbnail did not work well with new square crop on Quince and beyond versions of Open edX® LMS.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 29, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @jswope00! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

kdmccormick added a commit to kdmccormick/openedx-demo-course that referenced this pull request Feb 6, 2024
kdmccormick added a commit to kdmccormick/openedx-demo-course that referenced this pull request Feb 6, 2024
…uare cropping

The original thumbnail did not work well with new square crop on Quince
and beyond versions of Open edX® LMS.

Copied from: openedx-unsupported/openedx-demo-course-new#6

Co-Authored-By: John Swope <[email protected]>
@kdmccormick
Copy link
Contributor

Hey @jswope00 , we're ready to move development over to the official openedx-demo-course repository. I'm closing your PR here, but I've copied the changes into this openedx-demo-course PR.

@kdmccormick kdmccormick closed this Feb 6, 2024
@openedx-webhooks
Copy link

@jswope00 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

kdmccormick added a commit to kdmccormick/openedx-demo-course that referenced this pull request Feb 6, 2024
…uare cropping

The original tpu thumbnail did not work well with new square crop on Quince
and beyond versions of Open edX® LMS.

Copied from: openedx-unsupported/openedx-demo-course-new#6

Co-Authored-By: John Swope <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants