-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"as" comparatives broken in unit test #166
Comments
@linas As I commented on #149, I was thinking to represent the "as" comparatives the similar way as "than" comparatives, i.e. using "as" to connect the two comparison entities, the same way as "than" from the than-comparatives sentences. So according to the current representations, the sentence
will be represented as:
right? so, for the sentence "The kick was as soft as the first." can be represented:
Does it make sense to you? |
Oh, yes, right, makes perfect sense. The _predadj(kick, soft) confused me. Do you want _comparative(soft, kick) in addition to the predadj, or instead of it? |
anyway, the stuff that is currently in the unit test for these comparatives is wrong and/or unreviewd. And relex is probably broken for these, anyway ... |
I think we need both _predadj(kick, soft) and _comparative(soft, kick), as they will generate different logic representation for different meanings... |
See bug #155 and the comments there for
The kick was as soft as the first.
He is as smart as I ever expected him to be
which should probably be:
as(taste, do)
as(run, do)
as(soft, first)
as(smart, be)
The text was updated successfully, but these errors were encountered: