New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modernisation of the code #11

Open

flug opened this issue Jun 28, 2021 · 0 comments

Contributor

flug commented Jun 28, 2021

I think you should make a Config class for parameter management that you could extend with an ArrayAccess to have a pseudo toArray().

Then you should put the equivalent of your http client in PSR-7 and PSR-18 so that the implementations / tests etc... are much simpler.

Do you know what I mean?

https://github.com/opencoconut/coconutphp/blob/master/src/Client.php#L14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment