Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put configured callbackSystem in quotation marks #1466

Open
owi92 opened this issue Oct 2, 2024 · 2 comments
Open

Put configured callbackSystem in quotation marks #1466

owi92 opened this issue Oct 2, 2024 · 2 comments

Comments

@owi92
Copy link

owi92 commented Oct 2, 2024

I'm talking about the callbackSystem in the "Back to {callbackSystem}" button.

This seems unecessary when passing a name like "Tobira" or "Opencast", where you end up with a coherent sentence, but with names like "Videoportal Universität Bern (Tobira)", it might be a little clearer to delimit the name - that way it's super duper clear that we're not trying to build a gramatically correct sentence.

This was suggested in elan-ev/tobira#1232 (comment).

(If you are wondering why we don't just pass the quotation marks as part of the callbackSystem parameter in Tobira specifically: currently this uses the configured site title, and ideally this won't need a dedicated editor config section.)

@LukasKalbertodt
Copy link
Member

Alternatively, one could also use a slightly grey background and/or border around the {callbackSystem}.

@Arnei
Copy link
Member

Arnei commented Oct 2, 2024

I'm slightly against enforcing quotations marks, those likely don't make sense in every language. Lukas idea might be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants