Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitle Editor: It should not be possible to have overlapping subtitles #1396

Open
snoesberger opened this issue Jun 28, 2024 · 3 comments
Open
Labels
type:usability Usability improvements

Comments

@snoesberger
Copy link
Contributor

We don't think it should be possible to have overlapping subtitles. For example, if a user drags a subtitle box in the subtitle editor timeline and moves it over an existing box, the dragging box should shrink so that it starts/ends directly after/before the other box. The box can shrink to a minimal length and then can't be moved any further.

@snoesberger snoesberger added the type:usability Usability improvements label Jun 28, 2024
@Arnei
Copy link
Member

Arnei commented Jun 28, 2024

We don't think it should be possible to have overlapping subtitles.

Disagree with this. The WebVTT standard allows for overlapping cues. And we should accept any WebVTT as long as it is valid WebVTT. I am not in favor of disallowing or breaking perfectly valid subtitles.

I understand that subtitle editor usability could be better. But, I am also not generally in favor of preventing cues from overlapping while editing, as it is valid and likely necessary for some users. As such, I would ask that discussions on how to improve usability keep this in mind.

@snoesberger
Copy link
Contributor Author

Ok, I see your point. If someone uploads a valid vtt file with overlapping subtitles, we could run into all sorts of problems disallowing overlapping.

@mtneug
Copy link
Member

mtneug commented Jun 28, 2024

We don't think it should be possible to have overlapping subtitles.

Disagree with this. The WebVTT standard allows for overlapping cues. And we should accept any WebVTT as long as it is valid WebVTT. I am not in favor of disallowing or breaking perfectly valid subtitles.

I understand that subtitle editor usability could be better. But, I am also not generally in favor of preventing cues from overlapping while editing, as it is valid and likely necessary for some users. As such, I would ask that discussions on how to improve usability keep this in mind.

Yes, please follow the standard and allow all valid WebVTT files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:usability Usability improvements
Projects
None yet
Development

No branches or pull requests

3 participants