Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: reduce toil of manually sync workflows between contrib and core (generate-workflows-lib) #4263

Open
emdneto opened this issue Nov 8, 2024 · 1 comment
Assignees
Labels
build & infra Issues related to build & infrastructure. discussion Issue or PR that needs/is extended discussion.

Comments

@emdneto
Copy link
Member

emdneto commented Nov 8, 2024

Frequently we face situations when we change tox.ini in contrib (e.g., adding a new env or instrumentation or fixing a env name) we are required to manually update workflows in core as well (we need this to test core changes don't break contrib). Here are some PRs:

#4258
#4256
#4239
#4192
#4158

Maybe there's a better way to do that without the need to wait someone deal with a broken PR in core because tox -e generate-workflows is failing in CI.

Right now, the solution is: we need to manually fix workflows (i.e., run tox -e generate-workflows locally) and commit the changes (this is the process for keep workflows synced between -core and -contrib).

  1. We need to have this explicit in documentation as well.
  2. Investigate better way to automate this.
@emdneto emdneto added discussion Issue or PR that needs/is extended discussion. build & infra Issues related to build & infrastructure. labels Nov 8, 2024
@emdneto emdneto self-assigned this Nov 8, 2024
@xrmx
Copy link
Contributor

xrmx commented Nov 11, 2024

I think this is similar to open-telemetry/opentelemetry-python-contrib#2965 and that a fix for one will fix the other too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build & infra Issues related to build & infrastructure. discussion Issue or PR that needs/is extended discussion.
Projects
None yet
Development

No branches or pull requests

2 participants