Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Collector] Consume extension service with Ingress to give users a way to interact with them #3438

Open
Ankit152 opened this issue Nov 8, 2024 · 2 comments · May be fixed by #3441
Open
Labels
area:collector Issues for deploying collector enhancement New feature or request needs triage

Comments

@Ankit152
Copy link

Ankit152 commented Nov 8, 2024

Component(s)

collector

Is your feature request related to a problem? Please describe.

OpenTelemetry operator accepts custom configs in the spec to create all the resources on its behalf. Jaeger V2 follows the setting up of parameters using config files rather than passing them through the CLI flags in the command. The OTEL operator created resources like pods, deployments, service accounts, and services when custom configs were passed to create an OTEL instance for Jaeger V2. However, to interact with the UI, a forwarding port was required which is not something we should follow in a production environment.

Describe the solution you'd like

To cater this, a new method is being implemented that will create a new service explicitly for extensions. The newly created service will be consumed by the ingress to give users a way to directly interact with the ui (in Jaeger's case it's jaeger_query).

Since, the Operator has a parameter ingress which creates an Ingress according the specification set by the users themselves. Is it a good a idea to use the existing functionality?

Describe alternatives you've considered

Other way of creating ingress could be similar to the way extension service is being implemented. In this, we can create a method e.g., ExtensionIngress which will only be responsible for creating ingress for extensions. This will also leave less room for errors as it will automate the entire flow and users won't have to worry about them at all.

Additional context

Jaeger V2: jaegertracing/jaeger-operator#2717
Extension Service: #3403

@Ankit152 Ankit152 added enhancement New feature or request needs triage labels Nov 8, 2024
@Ankit152
Copy link
Author

Ankit152 commented Nov 8, 2024

@pavolloffay pavolloffay added the area:collector Issues for deploying collector label Nov 8, 2024
@pavolloffay
Copy link
Member

Once #3403 is merged we will be able to work on the ingress for the extension service.

I think we have two options to consider:

  1. add extension service flag to https://github.com/open-telemetry/opentelemetry-operator/blob/main/apis/v1beta1/ingress.go#L77
  2. expose another ingress in the top level spec https://github.com/open-telemetry/opentelemetry-operator/blob/main/apis/v1beta1/opentelemetrycollector_types.go#L113

@Ankit152 Ankit152 linked a pull request Nov 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:collector Issues for deploying collector enhancement New feature or request needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants