Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build tooling needed #1124

Open
MrAlias opened this issue Sep 24, 2024 · 1 comment
Open

Build tooling needed #1124

MrAlias opened this issue Sep 24, 2024 · 1 comment

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Sep 24, 2024

Similar to https://github.com/open-telemetry/opentelemetry-collector/tree/main/cmd/builder, we need a way to generate and then build a binary of the project.

Currently, if this repo is used as a library, it means that after loading the module a use needs to go to the package and run go generate to build the project. Ideally there would be tooling for this.

This becomes more important when we add custom probes.

@damemi
Copy link
Contributor

damemi commented Sep 24, 2024

Here's how Odigos generates the code from the library right now: https://github.com/odigos-io/odigos/blob/12171a085ec7ac4e80d6221de95b1374343a585f/odiglet/Makefile#L9-L14

If users are building a custom agent that imports our default Probes as well as their own custom Probes (#1105) this will need to run a similar command across multiple repos. Using go mod vendor might also be an approach we could recommend.

This tooling could take a similar config format to the collector builder that Tyler shared.

On the SIG call we also talked about this tool handling offset generation (will be needed for users to write custom Probes) and possibly generating Go code for a custom Probe to expose things like the Manifest and getting structfield IDs. In the latter, I think the tooling should be separate from the API types and just import them.

All in all this is going to be a pretty key toolkit for custom Probes and library users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants