Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx module logs debug info as errors #401

Open
nioncode opened this issue Mar 20, 2024 · 0 comments
Open

nginx module logs debug info as errors #401

nioncode opened this issue Mar 20, 2024 · 0 comments
Labels
Webserver This represents the otel-webserver-module in the instrumentation directory

Comments

@nioncode
Copy link

Most (all?) mod_opentelemetry logs use NGX_LOG_ERR severity (see e.g.

ngx_log_error(NGX_LOG_ERR, cycle->log, 0, "mod_opentelemetry: ngx_http_opentelemetry_init_worker: Initializing Nginx Worker for process with PID: %s", s);
)

This is not so nice, since those are expected messages and are not created because of errors, so it seems counter intuitive to print them as errors instead of as info or debug level. It would be great if the module would only print real errors as errors, as currently our logs regularly contain false positives and we need to post-process our logs to filter those out.

@marcalff marcalff added the Webserver This represents the otel-webserver-module in the instrumentation directory label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Webserver This represents the otel-webserver-module in the instrumentation directory
Projects
None yet
Development

No branches or pull requests

2 participants