Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

receiver/promettheusreceiver: add option to the metric adjuster to fallback to collector start time #36364

Open
ridwanmsharif opened this issue Nov 14, 2024 · 2 comments · May be fixed by #36365
Labels
enhancement New feature or request needs triage New item requiring triage receiver/prometheus Prometheus receiver

Comments

@ridwanmsharif
Copy link
Contributor

ridwanmsharif commented Nov 14, 2024

Component(s)

receiver/prometheusreceiver

Is your feature request related to a problem? Please describe.

When scraping prometheus metrics, there often are no start times associated with the cumulative metrics.
There is a metric adjuster that allows the configurer to specify another metric name from which to pull start time for all metrics scraped but I believe its useful to have a fallback mechanism to fall back to the collector start time.

This is useful especially in serverless workloads or workloads where the collector runs as a sidecar to the target being scraped. We currently use this approach for Cloud Run observability in https://github.com/GoogleCloudPlatform/run-gmp-sidecar/ and its been very useful there.

Describe the solution you'd like

An option added to the config, something like UseCollectorStartTimeFallback

Describe alternatives you've considered

No response

Additional context

No response

@ridwanmsharif ridwanmsharif added enhancement New feature or request needs triage New item requiring triage labels Nov 14, 2024
@dashpole dashpole added the receiver/prometheus Prometheus receiver label Nov 14, 2024
Copy link
Contributor

Pinging code owners for receiver/prometheus: @Aneurysm9 @dashpole. See Adding Labels via Comments if you do not have permissions to add labels yourself. For example, comment '/label priority:p2 -needs-triaged' to set the priority and remove the needs-triaged label.

@dashpole
Copy link
Contributor

cc @ArthurSens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage New item requiring triage receiver/prometheus Prometheus receiver
Projects
None yet
2 participants