Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hoist generateConfigFile function #213

Open
zeucapua opened this issue Oct 7, 2024 · 0 comments
Open

feat: hoist generateConfigFile function #213

zeucapua opened this issue Oct 7, 2024 · 0 comments
Labels
core team work 👀 needs triage

Comments

@zeucapua
Copy link
Contributor

zeucapua commented Oct 7, 2024 

          nit: This is more or less duplicated in the `generateOutputFile` function. This could be an opportunity to hoist up that functionality into a `pkg/` function since we do alot of reading / writing yamls. Probably best for an additional PR / ticket since there's plenty to refactor in that suggestions.

Originally posted by @jpmcb in #207 (comment)
@zeucapua zeucapua changed the title feat: hoist generateOutputFile function feat: hoist generateConfigFile function Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core team work 👀 needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zeucapua