Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collections Dialog: Dedicated close button #6882

Open
Haoran-Hu opened this issue Jul 21, 2020 · 3 comments · May be fixed by #7950
Open

Collections Dialog: Dedicated close button #6882

Haoran-Hu opened this issue Jul 21, 2020 · 3 comments · May be fixed by #7950
Assignees
@jessewashburn
Labels
in review low priority Newbie Friendly reopen? valid

Comments

@Haoran-Hu
Copy link
Member

There is no dedicated cancel button for Collections dialog. Adding a cancel button to exit the dialog instead of click on the page outside of the dialog may be a better practice.

Screenshot

Screen Shot 2020-07-20 at 9 20 58 PM
@paulbert paulbert changed the title Collections Dialog: Dedicated cancel button Collections Dialog: Dedicated close button Jul 21, 2020
@paulbert
Copy link
Member

Changing this to Close since it won't cancel an action.

@dyeh123 dyeh123 mentioned this issue Aug 19, 2020
Closed
@RheuX
Copy link
Member

RheuX commented Oct 29, 2024

im not totally sure if this is necessary or not, but i can see it being argued for both ways

@Mutugiii
Copy link
Member

Think we can go ahead an implement a close button for uniformity with other dialogs

@Mutugiii Mutugiii added valid and removed close? labels Dec 16, 2024
@jessewashburn jessewashburn linked a pull request Dec 17, 2024 that will close this issue
Open
@jessewashburn jessewashburn linked a pull request Dec 17, 2024 that will close this issue
collections: dedicated close button (fixes #6882) #7950
Open
@jessewashburn jessewashburn self-assigned this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessewashburn jessewashburn

Labels
in review low priority Newbie Friendly reopen? valid
Projects
None yet
Milestone
No milestone
5 participants
@paulbert @Mutugiii @RheuX @Haoran-Hu @jessewashburn