Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sign in with Github #6

Open
arky opened this issue Jul 22, 2021 · 1 comment
Open

Allow sign in with Github #6

arky opened this issue Jul 22, 2021 · 1 comment
Assignees
Labels
enhancement improving existing code or new feature priority/low

Comments

@arky
Copy link

arky commented Jul 22, 2021

Please allow users to reuse their github accounts to sign in.

We have trained users to use github, it would be good to allow them to reuse their accounts instead of creating new accounts that are limited to 24 hours.

@hellais hellais added enhancement improving existing code or new feature priority/low labels Jan 31, 2022
@agrabeli
Copy link
Member

agrabeli commented Jul 27, 2022

Hi @arky, thanks for the feedback (and for training users to use GitHub!).

While the email sent with the link refers to an "account", it's not really an account, as it's not uniquely tied to the user. We have now changed the interface a bit to no longer require a nickname, but only an email address (to which the login link is sent to).

We do not collect or store email address (they're only required for sending the login link), so the email addresses are not tied to users.

Users can easily login at any moment by merely adding an email address, and clicking on the login link sent to that address.

The 24h login limit helps encourage users to make multiple, smaller submissions (which may be reviewed and merged faster).

I think it's great that you've trained users to use GitHub, as they will need that for interacting with their pull request (which is opened automatically via the Test Lists Editor), to address any feedback shared by reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improving existing code or new feature priority/low
Projects
Status: No status
Development

No branches or pull requests

3 participants