From a66b5893b43644a042d5b468a905a932f4e46468 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Arturo=20Filast=C3=B2?= <arturo@filasto.net>
Date: Tue, 15 Oct 2024 12:36:15 +0200
Subject: [PATCH] Fix missing enabledByDefault in echcheck (#1655)

Closes: https://github.com/ooni/probe/issues/2807

## Checklist

- [ ] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [ ] reference issue for this pull request: <!-- add URL here -->
- [ ] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request: <!-- add URL here -->
- [ ] if you changed code inside an experiment, make sure you bump its
version number

<!-- Reminder: Location of the issue tracker:
https://github.com/ooni/probe -->

## Description

Please, insert here a more detailed description.
---
 internal/registry/echcheck.go     | 7 ++++---
 internal/registry/factory_test.go | 4 +---
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/internal/registry/echcheck.go b/internal/registry/echcheck.go
index 939cf3d15..f16a2da70 100644
--- a/internal/registry/echcheck.go
+++ b/internal/registry/echcheck.go
@@ -18,9 +18,10 @@ func init() {
 					*config.(*echcheck.Config),
 				)
 			},
-			canonicalName: canonicalName,
-			config:        &echcheck.Config{},
-			inputPolicy:   model.InputOptional,
+			canonicalName:    canonicalName,
+			config:           &echcheck.Config{},
+			enabledByDefault: true,
+			inputPolicy:      model.InputOptional,
 		}
 	}
 }
diff --git a/internal/registry/factory_test.go b/internal/registry/factory_test.go
index d4a3d8368..425cc5269 100644
--- a/internal/registry/factory_test.go
+++ b/internal/registry/factory_test.go
@@ -593,9 +593,7 @@ func TestNewFactory(t *testing.T) {
 			inputPolicy:      model.InputOrStaticDefault,
 		},
 		"echcheck": {
-			// Note: echcheck is not enabled by default because we just introduced it
-			// into 3.19.0-alpha, which makes it a relatively new experiment.
-			//enabledByDefault: false,
+			enabledByDefault: true,
 			inputPolicy: model.InputOptional,
 		},
 		"example": {