From 97a03e7fc877f8255ad78a50629120c3e282e7de Mon Sep 17 00:00:00 2001 From: pablodanswer Date: Sun, 29 Dec 2024 20:12:02 -0500 Subject: [PATCH] nit --- backend/onyx/auth/schemas.py | 9 --------- backend/onyx/auth/users.py | 5 ++--- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/backend/onyx/auth/schemas.py b/backend/onyx/auth/schemas.py index 836d42a1489..7a8621b2493 100644 --- a/backend/onyx/auth/schemas.py +++ b/backend/onyx/auth/schemas.py @@ -48,15 +48,6 @@ class UserCreate(schemas.BaseUserCreate): tenant_id: str | None = None -class UserUpdateWithRoleForManager(schemas.BaseUserUpdate): - """ - This schema is used internally by the UserManager class when creating or updating users - that require role updates. It allows passing the role without exposing it in all default endpoints. - """ - - role: UserRole - - class UserUpdate(schemas.BaseUserUpdate): """ Role updates are not allowed through the user update endpoint for security reasons diff --git a/backend/onyx/auth/users.py b/backend/onyx/auth/users.py index fb95c86cd3a..86556bfe8d1 100644 --- a/backend/onyx/auth/users.py +++ b/backend/onyx/auth/users.py @@ -55,7 +55,7 @@ from onyx.auth.invited_users import get_invited_users from onyx.auth.schemas import UserCreate from onyx.auth.schemas import UserRole -from onyx.auth.schemas import UserUpdateWithRoleForManager +from onyx.auth.schemas import UserUpdate from onyx.configs.app_configs import AUTH_TYPE from onyx.configs.app_configs import DISABLE_AUTH from onyx.configs.app_configs import EMAIL_CONFIGURED @@ -250,9 +250,8 @@ async def create( user = await self.get_by_email(user_create.email) # Handle case where user has used product outside of web and is now creating an account through web if not user.role.is_web_login() and user_create.role.is_web_login(): - user_update = UserUpdateWithRoleForManager( + user_update = UserUpdate( password=user_create.password, - role=user_create.role, is_verified=user_create.is_verified, ) user = await self.update(user_update, user)