Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint /ontologies_full is showing private ontologies #112

Open
imadbourouche opened this issue Dec 18, 2024 · 7 comments
Open

Endpoint /ontologies_full is showing private ontologies #112

imadbourouche opened this issue Dec 18, 2024 · 7 comments
Assignees
Labels

Comments

@imadbourouche
Copy link
Member

Description

The endpoint /ontologies_full is showing private ontologies

Test in : https://data.agroportal.lirmm.fr/ontologies_full?display=viewingRestriction&display_links=false&display_context=false

Screenshot

Screenshot from 2024-12-18 15-17-17

@imadbourouche imadbourouche self-assigned this Dec 18, 2024
@syphax-bouazzouni
Copy link

Can you reproduce it in bioportal ?

@imadbourouche
Copy link
Member Author

imadbourouche commented Dec 18, 2024

@alexskr
Copy link

alexskr commented Dec 18, 2024

/submissions has the same issue. See ncbo#76

@jonquet
Copy link

jonquet commented Dec 19, 2024

This might not necessarily be a problem. This endpoint is not visible, not documented, available only in the open code and now mentionned in this issue.

/ontologies_full return more information than /ontologies

https://data.agroportal.lirmm.fr/ontologies_full?&display_links=false&display_context=false
Capture d’écran 2024-12-19 à 08 50 08

https://data.agroportal.lirmm.fr/ontologies?&display_links=false&display_context=false
Capture d’écran 2024-12-19 à 08 51 35

Before taking a decision we need a listing of where this endpoint is being used in the code. Which views?

@syphax-bouazzouni
Copy link

@jonquet it used no where in the UI

@imadbourouche
Copy link
Member Author

@jonquet it's used no where also in the api, it's just declared as route to display ontologies + submissions + metrics.

@syphax-bouazzouni
Copy link

by the way @imadbourouche , the MOD API endpoint /artefacts/{artefactID} will follow the same idea as that /ontologyfull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants