Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Disable data upload on a study #364

Open
biblicabeebli opened this issue Mar 14, 2024 · 8 comments
Open

Feature - Disable data upload on a study #364

biblicabeebli opened this issue Mar 14, 2024 · 8 comments
Assignees
Labels
feature This is a New Thing!

Comments

@biblicabeebli
Copy link
Member

Make a (toggleable?) setting in study settings to shut down (block any new upload) a study.
Data download, dashboard, forest etc should remain available.

Presumably there should be a beiwe-app-side feature to Detect when the study is over.

@biblicabeebli biblicabeebli added the feature This is a New Thing! label Mar 14, 2024
@hydawo
Copy link
Collaborator

hydawo commented Apr 3, 2024

@biblicabeebli we would like to develop 2 separate features, both of which would stop all data upload to a study

  1. Disable upload/close study button on "Edit Study" page that is only accessible by Site-Admins. This would stop any further data upload to the study, but would not delete/hide the study. This button would be a toggle so it can be reversed if necessary.
  2. A field on "Edit Study" page that allows Site-Admins to designate a specific date at which time data upload would automatically stop.

@biblicabeebli
Copy link
Member Author

Work has begun on this feature, branch stop-studies. Have a vaguely-working, unfinished, no tests yet, prototype locally.

@biblicabeebli
Copy link
Member Author

There is now an end-date and manually end study feature implemented, it is on our staging server for testing.

Need to add an indicator that "the study you are looking at has ended."

@biblicabeebli
Copy link
Member Author

There are now some messages in the ... messages area telling the user that the study is stopped.
Pages are the main dashboard page, view study, edit study, edit study device settings pages.

@biblicabeebli
Copy link
Member Author

Made some more tests, fixed a bug, updated messages some.

@biblicabeebli
Copy link
Member Author

biblicabeebli commented Jul 16, 2024

"... This means that no further surveys will be sent out..."

I need to make sure it doesn't do that. That would be silly.

What happens if you try to pull the hidden study's data from the API?

It should fail, but it is kinda undefined behavior? I'll have to poke around and make sure we are locking it. It's possible that only some endpoints will fail/return no data, it should be universal.
(Context: This is the old "delete study" feature but it is now named appropriately. We never want to actually delete studies, so important details have gone unexamined. And I tend to forget about it.)

@biblicabeebli
Copy link
Member Author

I updated push notifications (schedules and other) they no longer work for ended, hidden, or manually stopped studies.

Authentication wrappers: they should already block hidden studies, they should NOT be made to block ended or manually stopped studies.

@biblicabeebli
Copy link
Member Author

biblicabeebli commented Jul 16, 2024

and now authentication wrappers all block hidden (internally "deleted") studies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This is a New Thing!
Projects
None yet
Development

No branches or pull requests

2 participants