Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.3.0 release does not have new import method #8

Open
DanHulton opened this issue Aug 1, 2023 · 6 comments
Open

0.3.0 release does not have new import method #8

DanHulton opened this issue Aug 1, 2023 · 6 comments

Comments

@DanHulton
Copy link
Contributor

I think the 0.3.0 version on npm did not have build run successfully on it before being published - it's missing the new await-free import method from #7.

If you update a project's dependency to 0.3.0 of this library and install it, then cat node_modules/typeid-ts/build/cjs/src/lib/basics.js, the old const uuidv7_1 = require("uuidv7"); require method is still there.

@marco-verbeek
Copy link

👋🏼 hello! Indeed, this seems to not have been published correctly.

@ongteckwu would it be possible to publish a new version with a fresh build ? 🙏🏼

Thank you!

@ongteckwu-assurity
Copy link

@marco-verbeek sure I will do that

@ongteckwu
Copy link
Owner

published, leet me know if it works marco

@marco-verbeek
Copy link

@ongteckwu
It seems like I'm still getting the same error on version 0.3.1.

/node_modules/typeid-ts/build/cjs/src/lib/basics.js:5
const uuidv7_1 = require("uuidv7");
                 ^
Error [ERR_REQUIRE_ESM]: require() of ES Module /home/marco/Repositories/easy-auth/node_modules/uuidv7/dist/index.js from /node_modules/typeid-ts/build/cjs/src/lib/basics.js not supported.
Instead change the require of index.js in /node_modules/typeid-ts/build/cjs/src/lib/basics.js to a dynamic import() which is available in all CommonJS modules.

Could you double check if the require is still there on your end as well ? 🙏🏼
Let me know if there's anything I can help with.

I highly appreciate your time, thank you so much!

@ongteckwu
Copy link
Owner

ok can you try again. Sorry was busy whole week.

@kodditor
Copy link

Still seeing the error in v0.3.8 @ongteckwu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants