Update node registration transaction

[tarakby]

Context

As part of the protocol BFT milestone (permissionless node participation), every new staking node has to share the proof of possession of its staking private key (PoP) with the protocol. The staking contract only accepts the registration if the PoP is valid. The purpose is to secure BLS signature aggregations in the Flow protocol.

Definition of Done

The node registration transaction needs to be updated to add a new field. Ledger needs to be able to parse the new field.

• Argument: stakingKeyPoP
• Type: String
• Description: The proof of possession of the staking private key as a hex-encoded string.

The new field is 48 bytes (96 hex characters).

Flow-port update is done under another ticket: https://github.com/onflow/flow-port/issues/183

[bthaile]

@tarakby How does stakingKeyPoP get created? Will the user simple paste it into the node registration form? Is there a smart contract change? If so has the change been made on testnet?

[tarakby]

@bthaile, good questions:

• the user should paste the stakingKeyPoP in the registration form on flow-port, exactly the way they do for the stakingKey. We will be updating the tools available for node operators so that they can generate stakingKeyPoP.
• Yes there is smart contract change, to be done in https://github.com/dapperlabs/flow-go/issues/6284. The updated contract is not on any network yet. I've noted this contract update as a blocker for testing Ledger/Flow-port changes.

[tarakby]

This issue is blocked till the manifest files are updated:

• https://github.com/onflow/ledger-app-flow/blob/master/tests/generate-transaction-tests/manifest.testnet.json
• https://github.com/onflow/ledger-app-flow/blob/master/tests/generate-transaction-tests/manifest.mainnet.json

This will be done by updating https://github.com/onflow/flow-core-contracts/blob/master/lib/go/templates/cmd/manifest/manifest.go as part of the contract updates https://github.com/dapperlabs/flow-go/issues/6284

[pgebheim]

@bthaile, good questions:

• the user should paste the stakingKeyPoP in the registration form on flow-port, exactly the way they do for the stakingKey. We will be updating the tools available for node operators so that they can generate stakingKeyPoP.
• Yes there is smart contract change, to be done in Add Proof of Possession Verification to Staking Node Registration dapperlabs/flow-go#6284. The updated contract is not on any network yet. I've noted this contract update as a blocker for testing Ledger/Flow-port changes.

Here is the flow-port ticket @bthaile
https://github.com/onflow/flow-port/issues/183

[tarakby]

@pgebheim what is the v0.10.1 milestone ? In case the milestone has a deadline, the completion of this ticket depends on Ledger external audit which usually doesn't have a clear timeline.

Btw, this is the complete epic : https://github.com/dapperlabs/flow-go/issues/6281

[pgebheim]

@pgebheim what is the v0.10.1 milestone ?

This milestone doenst have a deadline, it's just the next planned release number immediately after v0.10.0 is approved by ledger.