Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Access] Heartbeat interval not reset correctly in streaming endpoints. #6848

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Access] Heartbeat interval not reset correctly in streaming endpoints. #6848

wants to merge 1 commit into from
+5 −5

Conversation

AndriiDiachuk
Copy link
Contributor

Closes: #6837

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.29%. Comparing base (72adf9e) to head (d733364).

Files with missing lines Patch % Lines
engine/access/state_stream/backend/handler.go 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6848      +/-   ##
==========================================
+ Coverage   41.18%   41.29%   +0.11%     
==========================================
  Files        2109     2080      -29     
  Lines      185660   184023    -1637     
==========================================
- Hits        76460    76001     -459     
+ Misses     102788   101662    -1126     
+ Partials     6412     6360      -52
Flag Coverage Δ
unittests 41.29% <80.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

peterargue
peterargue approved these changes Jan 4, 2025
View reviewed changes
Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, but double check that test failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterargue peterargue peterargue approved these changes

@Guitarheroua Guitarheroua Awaiting requested review from Guitarheroua

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Access] Heartbeat interval not reset correctly in streaming endpoints
3 participants
@AndriiDiachuk @codecov-commenter @peterargue