Include human-friendly error messages on EVM transaction events #6836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6836 +/- ##
==========================================
- Coverage 41.12% 41.12% -0.01%
==========================================
Files 2107 2107
Lines 185330 185336 +6
==========================================
+ Hits 76220 76222 +2
- Misses 102710 102714 +4
Partials 6400 6400
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
m-Peter
force-pushed
the
mpeter/evm-events-abi-decode-assert-errors
branch
from
967e69d to
2d8eb89
Compare
m-Peter
force-pushed
the
mpeter/evm-events-abi-decode-assert-errors
branch
from
2d8eb89 to
7fb6ff4
Compare
Comment on lines
+67
to
+73
| errorMessage := p.Result.ErrorMsg() | ||
| if p.Result.ResultSummary().ErrorCode == types.ExecutionErrCodeExecutionReverted { | ||
| reason, errUnpack := abi.UnpackRevert(p.Result.ReturnedData) | ||
| if errUnpack == nil { | ||
| errorMessage = fmt.Sprintf("%v: %v", gethVM.ErrExecutionReverted.Error(), reason) | ||
| } | ||
| } |
There was a problem hiding this comment.
Can you make this a method on types.Result. Maybe call it ErrorMessageWithRevertReason or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6770