Adds NFTStorefrontV2 and USDCFlow to bootstrapping
#6611
Conversation
joshuahannan
requested review from
janezpodhostnik and
zhangchiqing
as code owners
|
Good idea to add these contracts! If the goal is to add these for mostly developer convenience, then the Emulator might be a better place to add this. Not sure if customizing/extending the bootstrapping is already possible so it can be done in the Emulator alone – if not maybe that's something that should be done here in flow-go, and then what the PR currently does (adding the contracts) should be moved to the Emulator. |
joshuahannan
force-pushed
the
add-usdc-to-bootstrap
branch
from
7009009 to
16708af
Compare
|
@turbolent yeah this never realized unfortunately #2812 maybe we can reopen the issue and then move things to emulator. |
|
Just taking a look at this again. What do we think is the best thing to do here? It is certainly easier for me to just do it like in this PR, but I totally understand if we'd rather use the emulator. Just will take some extra work for us to get that other emulator feature working and build in the deployment there |
|
I am a bit torn here; on one hand I like the idea of Foundation contracts to be bootstrapped, on the other hand, it is hard to retire stuff from bootstrap I guess. ( not sure if this is 100% true, just my guess ) I would vote for customized bootstrap, with this contract behind an option on bootstrap. ( in the mean time we can maybe put others also behind a flag ) |
|
See my comment on #2812 (comment). For not I'm not opposed to adding these two new contracts to flow-go if they help developers (and us). |
joshuahannan
force-pushed
the
add-usdc-to-bootstrap
branch
from
16708af to
2ba5ae5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6611 +/- ##
==========================================
+ Coverage 41.18% 41.20% +0.01%
==========================================
Files 2109 2109
Lines 185660 185701 +41
==========================================
+ Hits 76460 76514 +54
+ Misses 102788 102773 -15
- Partials 6412 6414 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Closes onflow/flow-emulator#535
Adds the
NFTStorefrontV2andUSDCFlowsmart contracts to the flow-go bootstrapping so they are automatically deployed to the emulator. Will make it easier for developers to test with these contracts without having to deploy them themselves.