-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiday are events not spanning all days #31
Comments
Yeah, there are definitely bugs with this, there are ways to get this working, but given the number of issues, and staleness, I doubt it'll get resolved. I've just applied fixes locally on a private fork. |
Thank you for pointing this out and trying to find a resolution. I unfortunately don't have time to work on this currently. @lrljoe you said you found a solution? Do you want to create a PR? I'll look into merging it. Thanks for your help with this. I do want to still support this calendar, I just have a backlog of work currently. |
@joshtorres - I do have a solution for this, just need to look at how best to document the behaviour! |
@lrljoe ok awesome. If you want to create a PR when you're ready, I'll look it over. |
@joshtorres - I'm in two minds about whether it should be a PR, or just some simple documentation to be honest! At the moment, my (pretty simple) modification allows for:
To do this smoothly I introduced these properties into the Events collection:
The only real change is over-riding getEventsForDay() I've had to reduce the font-size to fit it clearly into a screenshot, but this demonstrates the behaviour: Which was generated by:
At the moment I set a "multiday" property on the "event", which prevents the draggable behaviour, as I haven't had a proper chance to sort out linking the elements so that they drag together. |
@joshtorres - what do you think out of the following: Option 1
OR Option 2
Along with the relevant docs OR Option 3
Which option would you like a PR for |
I'm thinking just having Docs might be the best option, depending on how complicated it is. Since everyone won't need that functionality, it's probably not worth our time to reinvent it. If you want to do Option 2 so they have an example, that would be really nice and helpful, but having docs would already make it way better. Thanks! |
Self prompt so it doesn't slip off my radar, I'll look to write the docs this side of xmas covering how to implement MultiDay Spanning event and MultiDay Repeating event |
Using your demo code for conveneince, when setting a start date and end date, the event only shows on the start date and doesnt span across all days.
I have tried with both the multiday tag and without.
This was previously working but I have recently upgraded to Livewire 3 and laravel 11 - So guessing it is somewhat related.
I am runing php 8.2.
OR...
The text was updated successfully, but these errors were encountered: