-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
equals() comparing objects of different types #167
Comments
Wow. Thanks, @scuniff! That looks very much to be the case. Would you be interested in opening a PR? |
scuniff
changed the title
euqals() comparing objects of different types
equals() comparing objects of different types
Nov 10, 2023
scuniff
added a commit
to scuniff/omero-server
that referenced
this issue
Nov 10, 2023
It's been over a year since I've used Git, didn't realize how rusty I am. 😊 Please let me know how this Pull Request looks and if there's something more or different I should do to follow OME processes. Thanks, |
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Nov 11, 2023
Repository: ome/omero-server Excluded PRs: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#372 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/372/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Nov 12, 2023
Repository: ome/omero-server Excluded PRs: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#373 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/373/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Nov 13, 2023
Repository: ome/omero-server Excluded PRs: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#374 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/374/)
Doesn't look rusty at all. Thanks so much! |
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Nov 14, 2023
Repository: ome/omero-server Excluded PRs: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#375 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/375/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Nov 15, 2023
Repository: ome/omero-server Excluded PRs: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#376 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/376/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Nov 15, 2023
Repository: ome/omero-server Excluded PRs: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (user: kkoz) - PR 152 jburel 'Set class in doc' (user: jburel) - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' (user: jburel) - PR 116 dominikl 'Add method to get pixel min max' (user: dominikl) - PR 61 joshmoore 'Pass user executor to rendering tasks' (user: joshmoore) Already up-to-date. Generated by OMERO-build-push#1579 (https://latest-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/1579/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Nov 16, 2023
Repository: ome/omero-server Excluded PRs: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#377 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/377/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Nov 16, 2023
Repository: ome/omero-server Excluded PRs: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (user: kkoz) - PR 152 jburel 'Set class in doc' (user: jburel) - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' (user: jburel) - PR 116 dominikl 'Add method to get pixel min max' (user: dominikl) - PR 61 joshmoore 'Pass user executor to rendering tasks' (user: joshmoore) Already up-to-date. Generated by OMERO-build-push#1580 (https://latest-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/1580/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Nov 17, 2023
Repository: ome/omero-server Excluded PRs: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#378 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/378/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Nov 17, 2023
Repository: ome/omero-server Excluded PRs: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (user: kkoz) - PR 152 jburel 'Set class in doc' (user: jburel) - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' (user: jburel) - PR 116 dominikl 'Add method to get pixel min max' (user: dominikl) - PR 61 joshmoore 'Pass user executor to rendering tasks' (user: joshmoore) Already up-to-date. Generated by OMERO-build-push#1581 (https://latest-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/1581/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Nov 18, 2023
Repository: ome/omero-server Excluded PRs: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#379 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/379/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Nov 18, 2023
Repository: ome/omero-server Excluded PRs: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (user: kkoz) - PR 152 jburel 'Set class in doc' (user: jburel) - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' (user: jburel) - PR 116 dominikl 'Add method to get pixel min max' (user: dominikl) - PR 61 joshmoore 'Pass user executor to rendering tasks' (user: joshmoore) Already up-to-date. Generated by OMERO-build-push#1582 (https://latest-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/1582/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Nov 19, 2023
Repository: ome/omero-server Excluded PRs: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#380 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/380/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Nov 19, 2023
Repository: ome/omero-server Excluded PRs: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (user: kkoz) - PR 152 jburel 'Set class in doc' (user: jburel) - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' (user: jburel) - PR 116 dominikl 'Add method to get pixel min max' (user: dominikl) - PR 61 joshmoore 'Pass user executor to rendering tasks' (user: joshmoore) Already up-to-date. Generated by OMERO-build-push#1583 (https://latest-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/1583/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Nov 20, 2023
Repository: ome/omero-server Excluded PRs: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#381 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/381/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Nov 20, 2023
Repository: ome/omero-server Excluded PRs: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (user: kkoz) - PR 152 jburel 'Set class in doc' (user: jburel) - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' (user: jburel) - PR 116 dominikl 'Add method to get pixel min max' (user: dominikl) - PR 61 joshmoore 'Pass user executor to rendering tasks' (user: joshmoore) Already up-to-date. Generated by OMERO-build-push#1584 (https://latest-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/1584/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Nov 21, 2023
Repository: ome/omero-server Excluded PRs: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#382 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/382/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Nov 21, 2023
Repository: ome/omero-server Excluded PRs: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (user: kkoz) - PR 152 jburel 'Set class in doc' (user: jburel) - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' (user: jburel) - PR 116 dominikl 'Add method to get pixel min max' (user: dominikl) - PR 61 joshmoore 'Pass user executor to rendering tasks' (user: joshmoore) Already up-to-date. Generated by OMERO-build-push#1585 (https://latest-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/1585/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Nov 22, 2023
Repository: ome/omero-server Excluded PRs: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#383 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/383/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Nov 22, 2023
Repository: ome/omero-server Excluded PRs: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (user: kkoz) - PR 152 jburel 'Set class in doc' (user: jburel) - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' (user: jburel) - PR 116 dominikl 'Add method to get pixel min max' (user: dominikl) - PR 61 joshmoore 'Pass user executor to rendering tasks' (user: joshmoore) Already up-to-date. Generated by OMERO-build-push#1586 (https://latest-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/1586/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Nov 23, 2023
Repository: ome/omero-server Excluded PRs: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#384 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/384/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Nov 23, 2023
Repository: ome/omero-server Excluded PRs: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (user: kkoz) - PR 152 jburel 'Set class in doc' (user: jburel) - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' (user: jburel) - PR 116 dominikl 'Add method to get pixel min max' (user: dominikl) - PR 61 joshmoore 'Pass user executor to rendering tasks' (user: joshmoore) Already up-to-date. Generated by OMERO-build-push#1587 (https://latest-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/1587/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Nov 24, 2023
Repository: ome/omero-server Excluded PRs: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#385 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/385/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Nov 24, 2023
Repository: ome/omero-server Excluded PRs: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (user: kkoz) - PR 152 jburel 'Set class in doc' (user: jburel) - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' (user: jburel) - PR 116 dominikl 'Add method to get pixel min max' (user: dominikl) - PR 61 joshmoore 'Pass user executor to rendering tasks' (user: joshmoore) Already up-to-date. Generated by OMERO-build-push#1588 (https://latest-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/1588/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Nov 25, 2023
Repository: ome/omero-server Excluded PRs: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#386 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/386/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 5, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#486 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/486/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 6, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#487 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/487/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 7, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#488 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/488/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 8, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#489 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/489/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 9, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#490 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/490/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 10, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#491 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/491/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 11, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#492 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/492/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 12, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#493 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/493/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 13, 2024
Repository: ome/omero-server Excluded PRs: - PR 176 chris-allan 'Session bean actions should happen at `SYSTEM` priority' (status: failure) - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#494 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/494/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 14, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' - PR 176 chris-allan 'Session bean actions should happen at `SYSTEM` priority' - PR 177 chris-allan 'Swap default min and background thread limits' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#496 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/496/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 14, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' - PR 176 chris-allan 'Session bean actions should happen at `SYSTEM` priority' - PR 177 chris-allan 'Swap default min and background thread limits' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#497 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/497/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 14, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up to date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' - PR 176 chris-allan 'Session bean actions should happen at `SYSTEM` priority' - PR 177 chris-allan 'Swap default min and background thread limits' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#1 (https://BRANCHCI.openmicroscopy.org/jenkins/job/OMERO-build-push/1/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 15, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up to date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' - PR 176 chris-allan 'Session bean actions should happen at `SYSTEM` priority' - PR 177 chris-allan 'Swap default min and background thread limits' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#2 (https://BRANCHCI.openmicroscopy.org/jenkins/job/OMERO-build-push/2/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 15, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' - PR 176 chris-allan 'Session bean actions should happen at `SYSTEM` priority' - PR 177 chris-allan 'Swap default min and background thread limits' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#498 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/498/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 16, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up to date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' - PR 176 chris-allan 'Session bean actions should happen at `SYSTEM` priority' - PR 177 chris-allan 'Swap default min and background thread limits' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#3 (https://BRANCHCI.openmicroscopy.org/jenkins/job/OMERO-build-push/3/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 16, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' - PR 176 chris-allan 'Session bean actions should happen at `SYSTEM` priority' - PR 177 chris-allan 'Swap default min and background thread limits' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#499 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/499/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 17, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up to date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' - PR 176 chris-allan 'Session bean actions should happen at `SYSTEM` priority' - PR 177 chris-allan 'Swap default min and background thread limits' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#4 (https://BRANCHCI.openmicroscopy.org/jenkins/job/OMERO-build-push/4/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 17, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' - PR 176 chris-allan 'Session bean actions should happen at `SYSTEM` priority' - PR 177 chris-allan 'Swap default min and background thread limits' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#500 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/500/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 18, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up to date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' - PR 176 chris-allan 'Session bean actions should happen at `SYSTEM` priority' - PR 177 chris-allan 'Swap default min and background thread limits' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#5 (https://BRANCHCI.openmicroscopy.org/jenkins/job/OMERO-build-push/5/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 18, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' - PR 176 chris-allan 'Session bean actions should happen at `SYSTEM` priority' - PR 177 chris-allan 'Swap default min and background thread limits' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#501 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/501/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 19, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' - PR 176 chris-allan 'Session bean actions should happen at `SYSTEM` priority' - PR 177 chris-allan 'Swap default min and background thread limits' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#502 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/502/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 20, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' - PR 176 chris-allan 'Session bean actions should happen at `SYSTEM` priority' - PR 177 chris-allan 'Swap default min and background thread limits' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#503 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/503/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 20, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up to date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' - PR 176 chris-allan 'Session bean actions should happen at `SYSTEM` priority' - PR 177 chris-allan 'Swap default min and background thread limits' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#6 (https://BRANCHCI.openmicroscopy.org/jenkins/job/OMERO-build-push/6/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 21, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up to date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' - PR 176 chris-allan 'Session bean actions should happen at `SYSTEM` priority' - PR 177 chris-allan 'Swap default min and background thread limits' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#7 (https://BRANCHCI.openmicroscopy.org/jenkins/job/OMERO-build-push/7/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 21, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up-to-date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' - PR 176 chris-allan 'Session bean actions should happen at `SYSTEM` priority' - PR 177 chris-allan 'Swap default min and background thread limits' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#504 (https://snoopycrimecop-ci.openmicroscopy.org/jenkins/job/OMERO-build-push/504/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 22, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 168 scuniff 'ome#167 equals() comparing objects of different types' (user: scuniff) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Already up to date. Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' - PR 176 chris-allan 'Session bean actions should happen at `SYSTEM` priority' - PR 177 chris-allan 'Swap default min and background thread limits' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#8 (https://BRANCHCI.openmicroscopy.org/jenkins/job/OMERO-build-push/8/)
jburel
added a commit
that referenced
this issue
Mar 22, 2024
#167 equals() comparing objects of different types
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 23, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Updating 82d598f..f67fdb6 Previously merged: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' - PR 177 chris-allan 'Swap default min and background thread limits' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#9 (https://BRANCHCI.openmicroscopy.org/jenkins/job/OMERO-build-push/9/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 24, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Updating 82d598f..f67fdb6 Previously merged: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' - PR 177 chris-allan 'Swap default min and background thread limits' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#10 (https://BRANCHCI.openmicroscopy.org/jenkins/job/OMERO-build-push/10/)
snoopycrimecop
added a commit
to snoopycrimecop/omero-server
that referenced
this issue
Mar 25, 2024
Repository: ome/omero-server Excluded PRs: - PR 175 sbesson 'Bump org.postgresql:postgresql to version 42.2.28' (stage: draft) - PR 166 kkoz 'Experimenter group cache' (stage: draft) - PR 116 dominikl 'Add method to get pixel min max' (exclude comment) Updating 82d598f..f67fdb6 Previously merged: - PR 168 scuniff 'ome#167 equals() comparing objects of different types' Merged PRs: - PR 151 jburel 'bump org.openmicroscopy.project 5.6.0' - PR 152 jburel 'Set class in doc' - PR 177 chris-allan 'Swap default min and background thread limits' Conflicting PRs (not included): - PR 61 joshmoore 'Pass user executor to rendering tasks' Generated by OMERO-build-push#11 (https://BRANCHCI.openmicroscopy.org/jenkins/job/OMERO-build-push/11/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/ome/omero-server/blob/master/src/main/java/ome/services/ThumbnailBean.java#L1141
Looks like this code at line 1141 is not comparing objects of the same type
if (inProgress && !PROGRESS_VERSION.equals(thumbnailMetadata)) {
==================
Should the getVersion() method be added:
if (inProgress && !PROGRESS_VERSION.equals(thumbnailMetadata.getVersion())) {
like it is at line 1042?
The text was updated successfully, but these errors were encountered: