Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial review and cleanup #1

Open
3 of 5 tasks
joshmoore opened this issue May 20, 2020 · 8 comments
Open
3 of 5 tasks

Initial review and cleanup #1

joshmoore opened this issue May 20, 2020 · 8 comments
Assignees

Comments

@joshmoore
Copy link
Member

joshmoore commented May 20, 2020

https://anaconda.org/ome/bftools created with 6.3.1 for the community meeting.

  • review openjdk choice
  • activate travis or GitHub actions
  • unify travis files via imports (seealso: omero-py)
  • document use (likely via an example environment.yml)
  • add to release steps (or automate, e.g. by chaining repositories with event dispatch

All the above apply to the bioformats2raw and raw2ometiff packages.

cc: @sbesson @manics @dgault @jburel @melissalinkert

@joshmoore
Copy link
Member Author

Simple usage:

conda create -n bftools -c ome bftools

@joshmoore
Copy link
Member Author

Note: for openjdk builds on OS X, one needs to use conda-forge:

conda build -c conda-forge .

@joshmoore
Copy link
Member Author

Environment file for testing:

channels:
  - ome
  - conda-forge
  - defaults
dependencies:
  - openjdk=11
  - bftools
  - bioformats2raw
  - raw2ometiff

@manics
Copy link
Member

manics commented May 20, 2020

https://github.com/glencoesoftware/bioformats2raw/releases/tag/v0.2.2 was just released, does this mean you can remove conda-forge since the default version of openjdk should work?

Also this repo doesn't build for me on OS X:

$ git log -1
commit 00cd6449a79bff688cdf1b503bcd0138832c443e (HEAD -> master, origin/master, origin/HEAD)
Author: jmoore <[email protected]>
Date:   Wed May 20 08:29:23 2020 +0200

    Fix package name
$ conda build -c conda-forge .
No numpy version specified in conda_build_config.yaml.  Falling back to default numpy value of 1.11
WARNING:conda_build.metadata:No numpy version specified in conda_build_config.yaml.  Falling back to default numpy value of 1.11
Adding in variants from internal_defaults
INFO:conda_build.variants:Adding in variants from internal_defaults
Couldn't extract raw recipe text for bftools output
$ conda build .
No numpy version specified in conda_build_config.yaml.  Falling back to default numpy value of 1.11
WARNING:conda_build.metadata:No numpy version specified in conda_build_config.yaml.  Falling back to default numpy value of 1.11
Adding in variants from internal_defaults
INFO:conda_build.variants:Adding in variants from internal_defaults
Couldn't extract raw recipe text for bftools output

@joshmoore
Copy link
Member Author

joshmoore commented May 20, 2020

does this mean you can remove conda-forge

Yup, just testing that now.

Couldn't extract raw recipe text for bftools output

I don't know what to suggest there. Perhaps different versions of conda?

$ conda --version
conda 4.8.3
$ conda build --version
conda-build 3.7.1

@manics
Copy link
Member

manics commented May 20, 2020

$ conda --version
conda 4.7.11

$ conda build --version
conda-build 3.17.8

@joshmoore joshmoore self-assigned this May 20, 2020
@joshmoore
Copy link
Member Author

@manics : conda/conda-build#3267 (comment) seems to be the issue. Moving about: to the bottom.

@jburel
Copy link
Member

jburel commented Feb 17, 2021

#6
Follow up points from the PR

Two possible follow-up points:

* doesn't look like this is going to be overly generalizable into a template for the likes of conda-bioformats2raw/raw2ometiff
* at the same time, I image a move to conda-forge would also be useful in order to have the automatic updates when upstream changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants