Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate file in GCP bootstrap ignition #37

Closed
Rikbruggink opened this issue Jan 16, 2020 · 3 comments · Fixed by openshift/installer#3078
Closed

Duplicate file in GCP bootstrap ignition #37

Rikbruggink opened this issue Jan 16, 2020 · 3 comments · Fixed by openshift/installer#3078
Labels
platform/google
Milestone
Beta

Comments

@Rikbruggink
Copy link

With the current OKD installer there is a duplicate file in the GCP bootstrap proces. This file https://github.com/openshift/installer/blob/fcos/data/data/bootstrap/gcp/files/usr/local/bin/report-progress.sh needs to be removed or the bootstrap machine segfaults in its configuring fase before the machine is usable.

GCP support master ticket #11
@vrutkovs
Copy link
Member

This affects all systems: seems forked terraform ignition provider is incorrectly merging files, so bootstrap's motd is duplicated.

@vrutkovs vrutkovs mentioned this issue Feb 3, 2020
Closed
@LorbusChris
Copy link
Contributor

we recently switched tf ignition provider forks, so this might work now?

Otherwise, it could be related to hashicorp/terraform-provider-ignition#66 (comment)

@vrutkovs vrutkovs mentioned this issue Feb 7, 2020
Closed
@LorbusChris LorbusChris mentioned this issue Feb 7, 2020
Merged
@LorbusChris
Copy link
Contributor

xref: #11

@vrutkovs vrutkovs added this to the Beta milestone Feb 11, 2020
jdhirst added a commit to jdhirst/installer that referenced this issue Feb 12, 2020
@jdhirst
bootstrap: replace Ignition files if they are already defined
23d1f89 
instead of appending them.

This fixes an issue in Ignition Spec v3 where contradictory entries
in the Storage.Files array are not allowed.

Specifically, in order to solve okd-project/okd#37,
`data/data/bootstrap/gcp/files/usr/local/bin/report-progress.sh` will
now replace `data/data/bootstrap/files/usr/local/bin/report-progress.sh`
instead of being appended.

It also solves okd-project/okd#63 by ensuring
`99_openshift-machineconfig_99-{master,worker]-ssh.yaml` aren't added
to the generated Ignition config twice.
@jdhirst jdhirst mentioned this issue Feb 12, 2020
Merged
LorbusChris added a commit to LorbusChris/installer that referenced this issue Feb 22, 2020
@LorbusChris
bootstrap: replace Ignition files if they are already defined
e8b7213 
instead of appending them.

This fixes an issue in Ignition Spec v3 where contradictory entries
in the Storage.Files array are not allowed.

Specifically, in order to solve okd-project/okd#37,
`data/data/bootstrap/gcp/files/usr/local/bin/report-progress.sh` will
now replace `data/data/bootstrap/files/usr/local/bin/report-progress.sh`
instead of being appended.

It also solves okd-project/okd#63 by ensuring
`99_openshift-machineconfig_99-{master,worker]-ssh.yaml` aren't added
to the generated Ignition config twice.
LorbusChris added a commit to LorbusChris/installer that referenced this issue Feb 23, 2020
@LorbusChris
bootstrap: replace Ignition files if they are already defined
657c079 
instead of appending them.

This fixes an issue in Ignition Spec v3 where contradictory entries
in the Storage.Files array are not allowed.

Specifically, in order to solve okd-project/okd#37,
`data/data/bootstrap/gcp/files/usr/local/bin/report-progress.sh` will
now replace `data/data/bootstrap/files/usr/local/bin/report-progress.sh`
instead of being appended.

It also solves okd-project/okd#63 by ensuring
`99_openshift-machineconfig_99-{master,worker]-ssh.yaml` aren't added
to the generated Ignition config twice.
vrutkovs pushed a commit to vrutkovs/installer that referenced this issue Feb 26, 2020
@LorbusChris @vrutkovs
bootstrap: replace Ignition files if they are already defined
c0a480b 
instead of appending them.

This fixes an issue in Ignition Spec v3 where contradictory entries
in the Storage.Files array are not allowed.

Specifically, in order to solve okd-project/okd#37,
`data/data/bootstrap/gcp/files/usr/local/bin/report-progress.sh` will
now replace `data/data/bootstrap/files/usr/local/bin/report-progress.sh`
instead of being appended.

It also solves okd-project/okd#63 by ensuring
`99_openshift-machineconfig_99-{master,worker]-ssh.yaml` aren't added
to the generated Ignition config twice.
@vrutkovs vrutkovs mentioned this issue Feb 26, 2020
Closed
1 task
@1moere1 1moere1 mentioned this issue Mar 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
platform/google
Projects
None yet
Milestone
Beta
3 participants
@vrutkovs @Rikbruggink @LorbusChris