Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix : Filter badges visibility in resource page on selecting same date #10002

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix : Filter badges visibility in resource page on selecting same date #10002

wants to merge 4 commits into from

Conversation

Mahendar0701
Copy link
Contributor

@Mahendar0701 Mahendar0701 commented Jan 15, 2025 •
edited by coderabbitai bot
Loading

Proposed Changes

image

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Summary by CodeRabbit

  • Bug Fixes
    • Refined the parameter key handling in range filter badges to improve consistency when minimum and maximum values are identical.

@Mahendar0701 Mahendar0701 requested a review from a team as a code owner January 15, 2025 17:35
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 15, 2025 •
edited
Loading

Walkthrough

The pull request modifies the badgeUtils.range method in the useFilters hook, specifically changing how the parameter key is set when the minimum and maximum values of a range filter are identical. The change alters the way filter badges are generated for range filters with equal start and end values, potentially resolving an issue with badge visibility on the resource page.

Changes

File Change Summary
src/hooks/useFilters.tsx Modified badgeUtils.range method to set paramKey to paramKeys[0] when range values are equal

Assessment against linked issues

Objective Addressed Explanation
Filter badges visibility for same start/end date [#9999] ✅

Possibly related PRs

Suggested labels

tested, reviewed

Suggested reviewers

  • rithviknishad
  • bodhish

Poem

🐰 Filters dancing, badges bright
When start and end align just right
A tiny tweak, a code's delight
Making badges shine with might
Rabbit's magic makes it tight! 🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify Netlify
Copy link

netlify bot commented Jan 15, 2025 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit da3ea3b
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6789008c13b6710008c6a024
😎 Deploy Preview https://deploy-preview-10002--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Mahendar0701 Mahendar0701 changed the title Fix : Filter badges visibility on selecting same date Fix : Filter badges visibility in resource page on selecting same date Jan 15, 2025
coderabbitai[bot]
coderabbitai bot reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/hooks/useFilters.tsx (1)

132-136: Document the special handling of equal range values.

Consider adding a comment to explain why equal range values are handled differently. This will help future maintainers understand the rationale behind this behavior.

  if (values[0] === values[1])
+    // When min and max values are equal (e.g., same date selected),
+    // treat it as a single filter instead of a range to prevent duplicate badges
    return [{ name, value: values[0], paramKey: paramKeys[0] }];
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e98ab7 and fef5a93.

📒 Files selected for processing (1)
  • src/hooks/useFilters.tsx (1 hunks)
🔇 Additional comments (1)
src/hooks/useFilters.tsx (1)

133-133: LGTM! The fix correctly handles equal range values.

The change fixes the badge visibility issue by treating equal min/max values as a single filter parameter instead of a range. This is the correct behavior as it prevents duplicate badges when the same date is selected.

However, to prevent future regressions, consider adding test cases for:

  • Range with equal values (e.g., same date)
  • Range with different values
  • Edge cases (e.g., undefined values)

Would you like me to help generate the test cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@Jacobjeevan Jacobjeevan Jacobjeevan approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs review needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter badges are not visible in resource page
2 participants
@Mahendar0701 @Jacobjeevan