Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using selfClosing flag instead of a type #18

Open
igr opened this issue Dec 26, 2020 · 0 comments
Open

Consider using selfClosing flag instead of a type #18

igr opened this issue Dec 26, 2020 · 0 comments
Assignees
@igr
Labels
enhancement New feature or request

Comments

@igr
Copy link
Member

igr commented Dec 26, 2020

The one big difference from the spec is that Lagarto is not having the selfClosing flag, but only the type.

Using the type we cover all correct usages.

The only invalid usage is the end tag that is also self closed. Such a situation is currently reported as an error (according to spec) and the END tag is emitted (as it would be if we have the flag).

The only downside is that user is not able to figure out if the end tag was incorrectly self closing.
@igr igr added the enhancement New feature or request label Dec 26, 2020
@igr igr self-assigned this Dec 26, 2020
@igr igr changed the title Consider to use selfClosing flag instead of a type Consider using selfClosing flag instead of a type Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igr igr

Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
1 participant
@igr