Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Configurable step value #4

Open
obfuscurity opened this issue Apr 19, 2013 · 8 comments
Open

Configurable step value #4

obfuscurity opened this issue Apr 19, 2013 · 8 comments

Comments

@obfuscurity
Copy link
Owner

No description provided.

@obfuscurity
Copy link
Owner Author

Rather than needing to allow configuration of the step value we might be able to get by with applying a summarize(target, 10) to the query.

@whilp
Copy link

whilp commented Apr 20, 2013

Cubism applies summarize() under the hood in some cases. Where else do you need this?

@whilp whilp mentioned this issue Apr 20, 2013
@obfuscurity
Copy link
Owner Author

To be determined. As you've seen in #7, storage schemas can bite users in the ass. I'd love to be intelligent about this and perhaps query Graphite/Carbon for whisper metadata, but the only thing /metrics/get-metadata supports right now is fetching the aggregationMethod.

A better solution might be to query a single datapoint to see how many were returned by Graphite and adjust size instead.

@whilp
Copy link

whilp commented Apr 20, 2013

Yeah, I haven't had any good ideas about fixing this yet. Hrmph.

@flatiron32
Copy link

The metadata is part of the raw data. Raw data is two tuples separated by a pipe. This first is metadata and the second data. The metadata is name, timestamp of first value, timestamp of second value, and seconds between each value. Is more data needed to determine how to draw?

@obfuscurity
Copy link
Owner Author

Sorry I missed this earlier. Good idea. I'd be tempted to use format=raw for all of our data collection, but since we already use the Graphite context (and I'm too lazy to change it now), I'll probably just request it once as raw data to get the step before constructing the first cubism request.

@obfuscurity
Copy link
Owner Author

Cubism already uses format=raw to fetch data, so I'm not sure why they don't already adjust based on the step returned to them. Since we don't know what the range (from/until) will be when setting up the context (cubism determines it here) we'll either need to duplicate that logic in Dusk or monkeypatch(?) cubism.js to do what we want.

@whilp @flatiron32 Does this make sense to you guys?

@flatiron32
Copy link

Looking at cubism a bit closer, I think it is getting the step out here. Perhaps dusk does not need to pass a step at all.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants