pes_events_scanner: fix processing of RpmTransactionTasks

[pirat89]

RpmTransactionTasks messages have higher priority than instructions based on PES data. Previously, if multiple such messages existed with duplicate instructions, this could lead to the crash of the actor - especially in case when an existing package has been asked to be removed several times. Ensure the occurance of each instruction is unique (list -> set).

jira: RHEL-50076

Note: just written on knees without testing. Unit tests should be updated too.

[github-actions]

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

• review please @oamg/developers to notify leapp developers of the review request
• /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
However, here are additional useful commands for packit:

• /packit test to re-run manually the default tests
• /packit retest-failed to re-run failed tests manually
• /packit test oamg/leapp#42 to run tests with leapp builds for the leapp PR#42 (default is latest upstream - main - build)

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

• /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
• /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

[pirat89]

/packit copr-build

[MichalHe]

@pirat89 Although this fixes the crash, I believe that transaction configuration is handled in a weird manner altogether. If user says to_remove=['tomcat'] then the output of the pes_events_scanner actor will not contain tomcat in its to_remove fields -- see the failing unit test. Not sure whether this is intended (unlikely) but we (e.g. me) can fix this problem within this PR.

[pirat89]

@pirat89 Although this fixes the crash, I believe that transaction configuration is handled in a weird manner altogether. If user says to_remove=['tomcat'] then the output of the pes_events_scanner actor will not contain tomcat in its to_remove fields -- see the failing unit test. Not sure whether this is intended (unlikely) but we (e.g. me) can fix this problem within this PR.

@MichalHe you are right that this sounds weird. feel free to fix it properly in this PR - or close this one and open new one if you want. this has been really a draft to ilustrate what I found and initial possible fix of the problem. based on your finding, it seems there is something dirty still around.

[MichalHe]

@pirat89 I added a post-processing step that will add transaction configuration's fields to the scanner's output.

[MichalHe]

/packit build

[MichalHe]

I have tested the patch on a setup where I introduced an actor that produces:

self.produce(RpmTransactionTasks(to_remove=['tomcat', 'tomcat']))
self.produce(RpmTransactionTasks(to_remove=['tomcat']))

Using current upstream build, the upgrade crashed with the following error:

2025-01-09 16:31:15.324 ERROR    PID: 45901 leapp.workflow.FactsCollection: Actor pes_events_scanner has crashed: Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/leapp/repository/actor_definition.py", line 75, in _do_run
    actor_instance.run(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/leapp/actors/__init__.py", line 316, in run
    self.process(*args)
  File "/etc/leapp/repos.d/system_upgrade/common/actors/peseventsscanner/actor.py", line 41, in process
    process()
  File "/etc/leapp/repos.d/system_upgrade/common/actors/peseventsscanner/libraries/pes_events_scanner.py", line 512, in process
    source_pkgs = apply_transaction_configuration(source_pkgs)
  File "/etc/leapp/repos.d/system_upgrade/common/actors/peseventsscanner/libraries/pes_events_scanner.py", line 482, in apply_transaction_configuration
    source_pkgs_with_conf_applied.remove(pkg_name_to_pkg_info_map[pkg.name])
KeyError: tomcat:rhel-8-for-x86_64-appstream-rpms

Using build based on this PR results with no errors and the upgrade continues normally, without raising the above error.

Hence, I believe this PR is ready for review.

[pirat89]

giving +1 for @MichalHe changes. considering it good to go, but as original author of the PR, waiting for someone else to review it and merge it - even when my changes are minor in this PR.

[MichalHe]

The failing 9>10 tests are not related to this PR. Since two of us are OK with this PR, I am going to merge this.

[MichalHe]

looks OK to me, hence we have agreement of 2 developers. e2e tests are passing, so lets merge this