Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style popups #114

Open
mietcls opened this issue Jul 25, 2017 · 7 comments
Open

Style popups #114

mietcls opened this issue Jul 25, 2017 · 7 comments
Assignees
@ismakutl
Labels
design frontend

Comments

@mietcls
Copy link
Member

mietcls commented Jul 25, 2017 •
edited by xavez
Loading

The popup for adding a handle can use some love:

  • It’s not centered on the page
  • The black overlay is not covering the left most panel
  • It’s not styled yet
@ismakutl
Copy link
Contributor

ismakutl commented Jul 25, 2017 •
edited
Loading

Fixed styling + issue #116. Didn't style facebook, because we are not going to use that.
I will close this issue after it's reviewed.

@ismakutl ismakutl mentioned this issue Jul 25, 2017
Closed
@mietcls
Copy link
Member Author

mietcls commented Jul 25, 2017

@ismakutl what branch is this?

@ismakutl
Copy link
Contributor

ismakutl commented Jul 25, 2017 •
edited
Loading

@mietcls I did both in issue/branch #114.

@mietcls
Copy link
Member Author

mietcls commented Jul 25, 2017

@ismakutl A list of issues regarding to the popup: #120, #122, #123, #124, #125

@ismakutl
Copy link
Contributor

Can I work on this branch? Or should I make seperate branches for each issue?

@mietcls
Copy link
Member Author

mietcls commented Jul 25, 2017

Sure, work on this one, I should've maybe commented it here — sorry bout that!

@ismakutl
Copy link
Contributor

Solved these issues (#120, #122, #123) in the branch #114

ismakutl pushed a commit that referenced this issue Jul 26, 2017
Merge #114 with develop
f038792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ismakutl ismakutl

Labels
design frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xavez @mietcls @ismakutl