Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CONFIG_USE_middleware_freertos-kernel requires *-kernel_template and *-kernel_extension #185

Open
stefanct opened this issue Apr 3, 2024 · 3 comments
Assignees

Comments

@stefanct
Copy link

stefanct commented Apr 3, 2024

Describe the bug

The SDK's FreeRTOS setup requires CONFIG_USE_middleware_freertos-kernel_template and CONFIG_USE_middleware_freertos-kernel_extension to be set if CONFIG_USE_middleware_freertos-kernel is to be used (i.e., whenever FreeRTOS is selected).

The respective test is here and produces the typical "middleware_freertos-kernel dependency does not meet, please check..." message here.

I don't see a reason for this check at all... I noticed it because the template adds its own FreeRTOSConfig.h which in my case had precedence over my own config due to the order of include directories. This led to unwanted behavior.

To Reproduce

Should be rather obvious from the code but please ask if not!
This is with the source code from MCUX SDK 2.15.0.

Expected behavior

The extension and template should not be required by the base kernel (but the other way around only - which is not explicitly checked AFAICT, which is another bug hidden by this one).

Additional context

I simply deleted the whole check at line 47 and the corresponding else clause if no obvious ill intent.

@stefanct stefanct added the bug Something isn't working label Apr 3, 2024
@MichalPrincNXP MichalPrincNXP self-assigned this Apr 12, 2024
@MichalPrincNXP
Copy link
Contributor

Hello @stefanct , thanks for your report, it deals with known limitation. Extension and template is forced to be added into the project because we wanted

  • the useful extension/TAD being part of all available SDK FreeRTOS examples
  • to provide template in case user is not providing own FreeRTOSConfig.h
    I agree these two components should be optional (instead of required) but there is no simple way how to tell users that these optional components are available and could be added into project. Once being required, the user at least knows about them and can adjust CMakeLists.txt/config.cmake if not desired, like you did. We will try to focus on providing better user options definition in further SDK releases.
    Regards
    Michal

@MichalPrincNXP MichalPrincNXP removed the bug Something isn't working label Apr 12, 2024
@mttjcksn
Copy link

I just ran into this issue too. Separating the requirement for CONFIG_USE_middleware_freertos-kernel and CONFIG_USE_middleware_freertos-kernel_template would make a lot of sense, and I presume that was the original intention.

@MichalPrincNXP
Copy link
Contributor

Hello @stefanct , thank you for providing your inputs. As I indicted the user options definition and the way of defining components dependencies is going to be changed soon. Hope it will bring better user experience ...
Regards
Michal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants