From 725b75d83ffa51d5168bce84f3e353a1311911bd Mon Sep 17 00:00:00 2001 From: cary-rowen Date: Mon, 30 Dec 2024 22:45:33 +0800 Subject: [PATCH 1/4] Fix issue with certain SECTION elements not being recognized as editable controls in Visual Studio Code --- source/appModules/code.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/source/appModules/code.py b/source/appModules/code.py index facaeb60a1e..94b2f9bb590 100644 --- a/source/appModules/code.py +++ b/source/appModules/code.py @@ -26,10 +26,8 @@ def chooseNVDAObjectOverlayClasses(self, obj, clsList): clsList.insert(0, VSCodeDocument) def event_NVDAObject_init(self, obj: NVDAObject): - # This is a specific fix for Visual Studio Code, - # However, the root cause of the issue is issue #15159. - # Once issue #15159 is fixed, - # The PR #16248 that introduced this code can be immediately reverted. - # (see issue #15159 for full description) - if obj.role != controlTypes.Role.EDITABLETEXT: + # TODO: This is a specific fix for Visual Studio Code. + # Once the underlying issue is resolved, this workaround can be removed. + # See issue #15159 for more details. + if obj.role != controlTypes.Role.EDITABLETEXT and controlTypes.State.EDITABLE not in obj.states: obj.TextInfo = NVDAObjectTextInfo From 9afb8026011e247cdd767c19e96e10caee0517f5 Mon Sep 17 00:00:00 2001 From: cary-rowen Date: Mon, 30 Dec 2024 23:32:29 +0800 Subject: [PATCH 2/4] Update changes. --- user_docs/en/changes.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/user_docs/en/changes.md b/user_docs/en/changes.md index e7bbe509074..1c46d7d473f 100644 --- a/user_docs/en/changes.md +++ b/user_docs/en/changes.md @@ -182,12 +182,13 @@ Use `gui.message.MessageDialog` instead. (#17582) ## 2024.4.2 -This is a patch release to fix bugs with braille devices and reading math in Chromium. +This is a patch release to fix bugs with braille devices and reading math in Chromium, as well as an issue with NVDA reading certain editable text fields in Visual Studio Code. ### Bug fixes * Fixed bug with with reading math in Chromium Browsers (Chrome, Edge). (#17421, @NSoiffer) * Humanware Brailliant BI 40X devices running firmware version 2.4 now work as expected. (#17518, @bramd) +* Fix issue with certain SECTION elements not being recognized as editable controls in Visual Studio Code. (#17573, @Cary-rowen) ## 2024.4.1 From a318a4c837799d2ab32f5308dab7ef8c49fa0ebf Mon Sep 17 00:00:00 2001 From: cary-rowen Date: Thu, 9 Jan 2025 07:58:56 +0800 Subject: [PATCH 3/4] Move change entries to 2025.1 --- user_docs/en/changes.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/user_docs/en/changes.md b/user_docs/en/changes.md index 1c46d7d473f..355b6170a97 100644 --- a/user_docs/en/changes.md +++ b/user_docs/en/changes.md @@ -84,6 +84,7 @@ In any document, if the cursor is on the last line, it will be moved to the end * When the Standard HID Braille Display driver is explicitly selected as the braille display driver, and the braille display list is opened, NVDA correctly identifies the HID driver as the selected driver instead of showing no driver selected. (#17537, @LeonarddeR) * The Humanware Brailliant driver is now more reliable in selecting the right connection endpoint, resulting in better connection stability and less errors. (#17537, @LeonarddeR) * Custom braille tables in the developer scratchpad are now properly ignored when running with add-ons disabled. (#17565, @LeonarddeR) +* Fix issue with certain SECTION elements not being recognized as editable controls in Visual Studio Code. (#17573, @Cary-rowen) ### Changes for Developers @@ -182,13 +183,12 @@ Use `gui.message.MessageDialog` instead. (#17582) ## 2024.4.2 -This is a patch release to fix bugs with braille devices and reading math in Chromium, as well as an issue with NVDA reading certain editable text fields in Visual Studio Code. +This is a patch release to fix bugs with braille devices and reading math in Chromium. ### Bug fixes * Fixed bug with with reading math in Chromium Browsers (Chrome, Edge). (#17421, @NSoiffer) * Humanware Brailliant BI 40X devices running firmware version 2.4 now work as expected. (#17518, @bramd) -* Fix issue with certain SECTION elements not being recognized as editable controls in Visual Studio Code. (#17573, @Cary-rowen) ## 2024.4.1 From 0b96b255e07cc9996bace5c4f4d5a1b0cf8dd431 Mon Sep 17 00:00:00 2001 From: Sean Budd Date: Thu, 9 Jan 2025 11:05:41 +1100 Subject: [PATCH 4/4] Update user_docs/en/changes.md --- user_docs/en/changes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/user_docs/en/changes.md b/user_docs/en/changes.md index 355b6170a97..173a578d598 100644 --- a/user_docs/en/changes.md +++ b/user_docs/en/changes.md @@ -84,7 +84,7 @@ In any document, if the cursor is on the last line, it will be moved to the end * When the Standard HID Braille Display driver is explicitly selected as the braille display driver, and the braille display list is opened, NVDA correctly identifies the HID driver as the selected driver instead of showing no driver selected. (#17537, @LeonarddeR) * The Humanware Brailliant driver is now more reliable in selecting the right connection endpoint, resulting in better connection stability and less errors. (#17537, @LeonarddeR) * Custom braille tables in the developer scratchpad are now properly ignored when running with add-ons disabled. (#17565, @LeonarddeR) -* Fix issue with certain SECTION elements not being recognized as editable controls in Visual Studio Code. (#17573, @Cary-rowen) +* Fix issue with certain section elements not being recognized as editable controls in Visual Studio Code. (#17573, @Cary-rowen) ### Changes for Developers