From 5cfd88ae448ed2d818a3a9e7c58abcbb68bc070c Mon Sep 17 00:00:00 2001 From: Sean Budd Date: Thu, 18 Apr 2024 13:13:52 +1000 Subject: [PATCH 1/6] Reenable chrome tests --- tests/system/robot/chromeTests.robot | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/system/robot/chromeTests.robot b/tests/system/robot/chromeTests.robot index 7892b0b1414..c345cfc6f78 100644 --- a/tests/system/robot/chromeTests.robot +++ b/tests/system/robot/chromeTests.robot @@ -4,7 +4,7 @@ # For more details see: https://www.gnu.org/licenses/gpl-2.0.html *** Settings *** Documentation HTML test cases in Chrome -Force Tags NVDA smoke test browser chrome excluded_from_build +Force Tags NVDA smoke test browser chrome # for start & quit in Test Setup and Test Test Teardown Library NvdaLib.py From 9d39ab860fed6ba6f41f79c769494a9d1050cf21 Mon Sep 17 00:00:00 2001 From: Sean Budd Date: Wed, 12 Jun 2024 13:06:41 +1000 Subject: [PATCH 2/6] add no first run flag --- tests/system/libraries/_chromeArgs.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/system/libraries/_chromeArgs.py b/tests/system/libraries/_chromeArgs.py index 05e2f9f844c..4188ea5fcb8 100644 --- a/tests/system/libraries/_chromeArgs.py +++ b/tests/system/libraries/_chromeArgs.py @@ -14,6 +14,7 @@ def getChromeArgs() -> str: """ return ( "chrome" # Start Chrome + " --no-first-run" # Don't show intro pages for the first run of chrome " --force-renderer-accessibility" # don't rely on chrome detecting a screen reader. " --suppress-message-center-popups" # prevent popups that may interfere with automated tests. " --disable-notifications" # prevent notifications that may interfere with automated tests. From 88b79f09e44fec61017d09ae20f3a7adb14f9c5a Mon Sep 17 00:00:00 2001 From: Sean Budd Date: Wed, 12 Jun 2024 13:45:27 +1000 Subject: [PATCH 3/6] add more flags --- tests/system/libraries/_chromeArgs.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/system/libraries/_chromeArgs.py b/tests/system/libraries/_chromeArgs.py index 4188ea5fcb8..f358caa7349 100644 --- a/tests/system/libraries/_chromeArgs.py +++ b/tests/system/libraries/_chromeArgs.py @@ -16,6 +16,12 @@ def getChromeArgs() -> str: "chrome" # Start Chrome " --no-first-run" # Don't show intro pages for the first run of chrome " --force-renderer-accessibility" # don't rely on chrome detecting a screen reader. + " --force-app-mode" # Hides certain system elements + " --ash-no-nudges" # Prevents Chrome from showing nudge messages. + " --browser-test" # Enable browser test mode, helps reduce flakey tests + " --disable-default-apps" # Don't show default apps on the new tab page. + " --disable-background-networking" # Don't run network requests in the background. + " --keep-alive-for-test" # Reduces start/stop time by keeping the app alive with no windows open. " --suppress-message-center-popups" # prevent popups that may interfere with automated tests. " --disable-notifications" # prevent notifications that may interfere with automated tests. " --no-experiments" # Stable behavior is preferred. From 32fb0923a5484db312bcb0bea9bfca4901c5b045 Mon Sep 17 00:00:00 2001 From: Sean Budd Date: Wed, 12 Jun 2024 14:17:03 +1000 Subject: [PATCH 4/6] remove certain flags --- tests/system/libraries/_chromeArgs.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/system/libraries/_chromeArgs.py b/tests/system/libraries/_chromeArgs.py index f358caa7349..d8475f0aeda 100644 --- a/tests/system/libraries/_chromeArgs.py +++ b/tests/system/libraries/_chromeArgs.py @@ -16,11 +16,9 @@ def getChromeArgs() -> str: "chrome" # Start Chrome " --no-first-run" # Don't show intro pages for the first run of chrome " --force-renderer-accessibility" # don't rely on chrome detecting a screen reader. - " --force-app-mode" # Hides certain system elements " --ash-no-nudges" # Prevents Chrome from showing nudge messages. " --browser-test" # Enable browser test mode, helps reduce flakey tests " --disable-default-apps" # Don't show default apps on the new tab page. - " --disable-background-networking" # Don't run network requests in the background. " --keep-alive-for-test" # Reduces start/stop time by keeping the app alive with no windows open. " --suppress-message-center-popups" # prevent popups that may interfere with automated tests. " --disable-notifications" # prevent notifications that may interfere with automated tests. From e7a1be45b531b27f1ad83896d13a5a182ab722ff Mon Sep 17 00:00:00 2001 From: Sean Budd Date: Wed, 12 Jun 2024 15:12:20 +1000 Subject: [PATCH 5/6] disable broken tests --- tests/system/robot/chromeTests.robot | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/system/robot/chromeTests.robot b/tests/system/robot/chromeTests.robot index 82126b0f75e..4df586c4735 100644 --- a/tests/system/robot/chromeTests.robot +++ b/tests/system/robot/chromeTests.robot @@ -91,9 +91,13 @@ ARIA roleDescription focus ARIA roleDescription inline browse mode [Documentation] Read an inline element with a custom role in browse mode test_ariaRoleDescription_inline_browseMode + # Disabled due to chrome message "To get missing image descriptions, open the context menu." + [Tags] excluded_from_build ARIA roleDescription block browse mode [Documentation] Read a block element with a custom role in browse mode test_ariaRoleDescription_block_browseMode + # Disabled due to chrome message "To get missing image descriptions, open the context menu." + [Tags] excluded_from_build ARIA roleDescription inline content editable [Documentation] Read an inline element with a custom role in content editables test_ariaRoleDescription_inline_contentEditable @@ -159,9 +163,11 @@ i13307 textParagraphNavigation [Documentation] Text paragraph navigation test_textParagraphNavigation + [Tags] excluded_from_build styleNav [Documentation] Same style navigation test_styleNav + [Tags] excluded_from_build aria-errormessage [Documentation] Test that aria-errormessage is reported correctly in focus and browse mode test_ariaErrorMessage From 6bc42c8e9052b5473b4d3dc0dcb01d67f194df55 Mon Sep 17 00:00:00 2001 From: Sean Budd Date: Wed, 12 Jun 2024 15:51:14 +1000 Subject: [PATCH 6/6] fix up exclusions --- tests/system/robot/chromeTests.robot | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/system/robot/chromeTests.robot b/tests/system/robot/chromeTests.robot index 4df586c4735..add82bbcda7 100644 --- a/tests/system/robot/chromeTests.robot +++ b/tests/system/robot/chromeTests.robot @@ -97,10 +97,10 @@ ARIA roleDescription block browse mode [Documentation] Read a block element with a custom role in browse mode test_ariaRoleDescription_block_browseMode # Disabled due to chrome message "To get missing image descriptions, open the context menu." - [Tags] excluded_from_build ARIA roleDescription inline content editable [Documentation] Read an inline element with a custom role in content editables test_ariaRoleDescription_inline_contentEditable + [Tags] excluded_from_build ARIA roleDescription block content editable [Documentation] Read an block element with a custom role in content editables test_ariaRoleDescription_block_contentEditable