Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVDA fails to announce capital letters when pitch is set to 0 #10940

Open
lukaszgo1 opened this issue Apr 4, 2020 · 6 comments · May be fixed by #13921
Open

NVDA fails to announce capital letters when pitch is set to 0 #10940

lukaszgo1 opened this issue Apr 4, 2020 · 6 comments · May be fixed by #13921
Labels
bug/regression p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.

Comments

@lukaszgo1
Copy link
Contributor

lukaszgo1 commented Apr 4, 2020

Steps to reproduce:

  1. Switch to eSpeak
  2. Enable "Say 'cap' before capitals"
  3. Ensure that "capital pitch change percentage" is set to value different than 0
  4. Set pitch to 0
  5. Try to read character by character "aA"

Actual behavior:

When encountering capital letter the error sound is played and the following is in the log:

error executing script: <bound method EditableText.script_caret_moveByCharacter of <NVDAObjects.Dynamic_IAccessibleEditWindowNVDAObject object at 0x074AE1D0>> with gesture 'left arrow'
Traceback (most recent call last):
  File "scriptHandler.pyc", line 205, in executeScript
  File "editableText.pyc", line 223, in script_caret_moveByCharacter
  File "editableText.pyc", line 164, in _caretMovementScriptHelper
  File "NVDAObjects\behaviors.pyc", line 175, in _caretScriptPostMovedHelper
  File "editableText.pyc", line 150, in _caretScriptPostMovedHelper
  File "speech\__init__.pyc", line 1080, in speakTextInfo
  File "speech\__init__.pyc", line 767, in speak
  File "speech\manager.pyc", line 164, in speak
  File "speech\manager.pyc", line 298, in _pushNextSpeech
  File "synthDrivers\espeak.pyc", line 110, in speak
  File "speech\commands.pyc", line 152, in multiplier
ZeroDivisionError: float division by zero

Expected behavior:

The capital letter should be read.

System configuration

NVDA installed/portable/running from source:

Portable

NVDA version:

Latest Alpha

Windows version:

Windows 7 x64

Name and version of other software in use when reproducing the issue:

Notepad

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

It works as expected in 2019.2.1 and fails in 2019.3

If addons are disabled, is your problem still occuring?

Yes

Did you try to run the COM registry fixing tool in NVDA menu / tools?

Not relevant

cc @feerrenrut @michaelDCurran

@LeonarddeR
Copy link
Collaborator

Did this work on Python 2 versions of NVDA? I guess this applies to almost every synthesizer.

@LeonarddeR LeonarddeR added bug/regression p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority labels Apr 4, 2020
@LeonarddeR
Copy link
Collaborator

Marking this p3, as it is unlikely that one would feel very comfortable with having synthesizer pitch at 0. Having said that, it should be pretty easy to fix.

@Brian1Gaff
Copy link

Brian1Gaff commented Apr 5, 2020 via email

@Adriani90
Copy link
Collaborator

I think this is related to #10896 and indeed might hav been appeared after migrating to Python 3.

@Qchristensen
Copy link
Member

I can replicate this with Windows OneCore as well as eSpeak-NG, so I don't think it is an eSpeak-NG issue.

I just tried in NVDA 2019.2.1 (pre Python 3) and cannot replicate this issue then, so it may be something which came in with Python 3.

Investigated as someone reported via Twitter, however I agree this is not likely to be a commonly encountered situation.

Twitter thread: https://twitter.com/mhussaincov/status/1539558402434777088

@seanbudd seanbudd changed the title eSpeak fails to announce capital letters when pitch is set to 0 NVDA fails to announce capital letters when pitch is set to 0 Jul 19, 2022
@seanbudd seanbudd linked a pull request Jul 19, 2022 that will close this issue
5 tasks
@seanbudd seanbudd added the triaged Has been triaged, issue is waiting for implementation. label Jul 19, 2022
@feerrenrut
Copy link
Contributor

A different but similar issue:
#9811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/regression p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants