-
-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gui.messageBox does not allow button renaming #12344
Comments
For what it's worth, I have made the change to wx.MessageDialog inside of gui.messageBox, and have added keyword arguments for the various Set*Label(s) calls, in a test build. |
michaelDCurran
pushed a commit
that referenced
this issue
Dec 20, 2024
This reverts commit 2477780. Reverts #17304 Issues fixed Fixes #17560 Fixes #17553 Issues reopened Reopens #13007 Reopens #12344 Reopens #12353 Reason for revert This PR broke two important NVDA functions, and there is insufficient time before the Christmas/New Years break to fix the issues, so we are temporarily reverting so that alphas work over the break: • The CRFT no longer works, as gui.message.MessageDialog's inheritance from ContextHelpMixin was accidentally removed. • Update checking no longer works, as runScriptModalDialog was modified to increment and decrement _messageBoxCounter, but UpdateAskInstallDialog attempts to restart NVDA before it has been closed, so the update fails as NVDA appears to be in an unsafe state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
I was trying to implement some code for a proposal of a UX bug fix.
It would have been convenient to use a dialog containing "Cancel" and "Continue" buttons.
If I was to do that in an add-on, it would be straight forward:
wx.messageDialog
, with thewx.OK | wx.CANCEL
flags, in a context handler..SetOKLabel("Continue")
on the context handler instance.However, the docstring for gui.messageBox states:
Describe the solution you'd like
git blame
.Describe alternatives you've considered
See #12353 for a potentially more acceptable alternative.
Additional context
This appears to have been introduced by @jcsteh in 3ebc8fd, as a means of preventing message dialogs and settings dialogs from stepping on each other and causing strange behavior (freezes), by being open at the same time.
Therefore I'm not suggesting relaxing the requirement to use gui.messageBox. I merely ask that we be able to expand its capabilities a bit.
The text was updated successfully, but these errors were encountered: