Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

Make the panel slide-in faster #11

Open
damithc opened this issue Jul 9, 2017 · 6 comments
Open

Make the panel slide-in faster #11

damithc opened this issue Jul 9, 2017 · 6 comments
Labels

Comments

@damithc
Copy link

damithc commented Jul 9, 2017

The extension is for users who want to do things fast. The slide-in speed of the panel is a bit too slow for such users. I find myself already typing label names while in the panel is still sliding-in, and sometimes it result in unexpected behavior.

@jiajunGit
Copy link
Collaborator

@damithc I have added a fix for this issue in commit 4de1946. Could you check to see if the input gains focus quick enough when the panel is sliding in? Thanks.

Besides the panel sliding out due to the input not gaining focus fast enough when typing, are there any other unexpected behaviors you have experienced due to this issue?

@damithc
Copy link
Author

damithc commented Jul 9, 2017

If I type L, wait for panel to appear, and type L again: p.Low is selected, as expected.
If I type L and L without waiting, the panel aborts the slide-in halfway and slides out again.

@damithc
Copy link
Author

damithc commented Jul 9, 2017

Seems to be fixed. It seems I didn't update properly when I wrote the previous comment. 👍

@damithc damithc closed this as completed Jul 9, 2017
@damithc
Copy link
Author

damithc commented Jul 14, 2017

The problem still persists if I type fast enough. e.g. If you type L and A fast enough, the labels panels slide in is aborted halfway and the assignees field in the page get activated instead.

@damithc damithc reopened this Jul 14, 2017
jiajunGit added a commit that referenced this issue Jul 17, 2017
@jiajunGit
Copy link
Collaborator

jiajunGit commented Jul 18, 2017

@damithc Could you check to see if this issue is resolved on your side? Thanks! (The fix should be in version 1.0.1)

@damithc
Copy link
Author

damithc commented Jul 18, 2017

Yes, seems so. First I have to wait till the panel icon appears, but after that even a very fast L A gets me the right label. The problem persists if I type L A before the panel icon appears, but that is unavoidable I guess.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants